feat: Adds Line chart migration logic by michael-s-molina · Pull Request #23973 · apache/superset

michael-s-molina · 2023-05-08T22:08:50Z

SUMMARY

This PR adds the Line chart migration logic (NVD3 ➡️ ECharts). Users can execute this migration using the migrate_viz CLI command and disable the legacy version with the VIZ_TYPE_DENYLIST configuration.

@sadpandajoe @jinghua-qa

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

1 - Upgrade a Line chart using the CLI command
2 - Check the new chart
3 - Downgrade a Line chart using the CLI command
4 - Check the legacy chart

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

john-bodley · 2023-10-31T20:20:59Z

    AREA = "area"
    PIVOT_TABLE = "pivot_table"
    SUNBURST = "sunburst"
+    LINE = "line"


john-bodley · 2023-10-31T20:22:45Z

+    has_x_axis_control = True
+
+    def _pre_action(self) -> None:
+        self.data["contributionMode"] = "row" if self.data.get("contribution") else None


Is this (and other attributes) required? Generally if not I think it's cleaner/safer to leave these undefined and fallback to the default.

These rules were added to keep visual consistency between the previous and new versions.

john-bodley · 2023-10-31T20:23:53Z

+
+    def _pre_action(self) -> None:
+        self.data["contributionMode"] = "row" if self.data.get("contribution") else None
+        self.data["zoomable"] = False if self.data.get("show_brush") == "no" else True


Suggested change

self.data["zoomable"] = False if self.data.get("show_brush") == "no" else True

self.data["zoomable"] = self.data.get("show_brush") != "no"

john-bodley · 2023-10-31T20:24:58Z

+        ):
+            self.data["bottom_margin"] = 30
+
+        if (rolling_type := self.data.get("rolling_type")) and rolling_type != "None":


Any reason rolling_type is "None" as opposed to None?

Many of these safe checks were added as a result of trying to run this migration using our production database which contained really old charts and inconsistent values.

john-bodley · 2023-10-31T20:25:53Z

+
+        if time_compare := self.data.get("time_compare"):
+            self.data["time_compare"] = [
+                value + " ago" for value in as_list(time_compare) if value


Are there causes when value is falsy?

Same as above.

pull-request-size Bot added the size/M label May 8, 2023

michael-s-molina added risk:breaking-change Issues or PRs that will introduce breaking changes hold! On hold v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch labels May 8, 2023

michael-s-molina force-pushed the migrate-line branch from 3e8840d to bcfb878 Compare May 9, 2023 13:24

michael-s-molina force-pushed the migrate-line branch from bcfb878 to 7791b92 Compare May 22, 2023 16:06

pull-request-size Bot added size/L and removed size/M labels May 22, 2023

john-bodley reviewed May 22, 2023

View reviewed changes

Comment thread superset/migrations/shared/migrate_viz/processors.py Outdated

john-bodley reviewed May 22, 2023

View reviewed changes

Comment thread superset/migrations/shared/migrate_viz/processors.py Outdated

michael-s-molina force-pushed the migrate-line branch from 7791b92 to 3480a33 Compare May 23, 2023 12:22

michael-s-molina removed the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Jun 26, 2023

michael-s-molina mentioned this pull request Jul 17, 2023

feat: migrate charts on import #24703

Merged

9 tasks

michael-s-molina mentioned this pull request Jul 31, 2023

Date column in superset displayed as unix timestamp #21508

Closed

3 tasks

michael-s-molina force-pushed the migrate-line branch from 3480a33 to 808c8ac Compare September 18, 2023 14:53

pull-request-size Bot added size/M and removed size/L labels Sep 18, 2023

michael-s-molina removed risk:breaking-change Issues or PRs that will introduce breaking changes hold! On hold labels Sep 18, 2023

michael-s-molina requested review from jinghua-qa and rusackas September 19, 2023 14:10

michael-s-molina marked this pull request as ready for review September 19, 2023 14:11

michael-s-molina requested a review from a team as a code owner September 19, 2023 14:11

michael-s-molina changed the title ~~feat: Migrates Line chart~~ feat: Adds Line chart migration logic Sep 19, 2023

michael-s-molina force-pushed the migrate-line branch from 1df9eb4 to 0200172 Compare September 19, 2023 17:39

michael-s-molina requested a review from kgabryje September 19, 2023 17:53

michael-s-molina mentioned this pull request Sep 20, 2023

feat: Adds the ECharts Bubble chart #22107

Merged

9 tasks

john-bodley reviewed Sep 25, 2023

View reviewed changes

Comment thread superset/migrations/shared/migrate_viz/processors.py Outdated

Comment thread superset/migrations/shared/migrate_viz/processors.py Outdated

Comment thread superset/migrations/shared/migrate_viz/processors.py Outdated

feat: Migrates Line chart

a3f571b

michael-s-molina added 3 commits October 31, 2023 16:24

Adjusts time_compare

8de3ebb

Adds Line to the CLI command

9f1fde0

Fixes import order

f09881a

michael-s-molina force-pushed the migrate-line branch from e39fa2c to f09881a Compare October 31, 2023 19:41

michael-s-molina requested a review from john-bodley October 31, 2023 19:43

john-bodley reviewed Oct 31, 2023

View reviewed changes

Addresses comments

de60756

michael-s-molina requested a review from john-bodley November 1, 2023 12:34

john-bodley approved these changes Nov 9, 2023

View reviewed changes

michael-s-molina merged commit 83b7fa9 into apache:master Nov 9, 2023

josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024

feat: Adds Line chart migration logic (apache#23973)

f9bdb9e

cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024

feat: Adds Line chart migration logic (apache#23973)

93bff7e

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 First shipped in 3.1.0 labels Mar 13, 2024

vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024

feat: Adds Line chart migration logic (apache#23973)

c5307e1

qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026

feat: Adds Line chart migration logic (apache#23973)

7ca7dac

	self.data["zoomable"] = False if self.data.get("show_brush") == "no" else True
	self.data["zoomable"] = self.data.get("show_brush") != "no"

Conversation

michael-s-molina commented May 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

john-bodley Oct 31, 2023

Choose a reason for hiding this comment

Uh oh!

john-bodley Oct 31, 2023

Choose a reason for hiding this comment

Uh oh!

michael-s-molina Nov 1, 2023

Choose a reason for hiding this comment

Uh oh!

john-bodley Oct 31, 2023

Choose a reason for hiding this comment

Uh oh!

john-bodley Oct 31, 2023

Choose a reason for hiding this comment

Uh oh!

michael-s-molina Nov 1, 2023

Choose a reason for hiding this comment

Uh oh!

john-bodley Oct 31, 2023

Choose a reason for hiding this comment

Uh oh!

michael-s-molina Nov 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

michael-s-molina commented May 8, 2023 •

edited

Loading

michael-s-molina Nov 1, 2023 •

edited

Loading