chore: Comment 3.8 PY required CI checks#24002
Merged
villebro merged 1 commit intoMay 10, 2023
Merged
Conversation
EugeneTorap
changed the title
villebro
reviewed
May 10, 2023
Member
villebro
left a comment
villebro
left a comment
There was a problem hiding this comment.
While I agree that this is the end state we want to achieve, this change will block all other PRs until the CI bump PR is merged. So if we run into trouble with it we're screwed and may need ASF help to unblock us. Let's rather remove the required 3.8 tests, leave the 3.9 ones and reintroduce the 3.8 and 3.9 ones as 3.9 and 3.10 respectively after the CI update has been merged, just to be safe.
EugeneTorap
changed the title
EugeneTorap
force-pushed
the
chore/update-required-status-checks-for-ci
branch
from
897a98f to
e822761
Compare
villebro
approved these changes
May 10, 2023
Member
villebro
left a comment
villebro
left a comment
There was a problem hiding this comment.
LGTM - Let's try to follow up quickly with the next step so we can re-enable the bumped workflows
dpgaspar
approved these changes
May 10, 2023
mistercrunch
added
🏷️ bot
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Before remove 3.8 PY support and bump to 3.9 PY version in #23890 we need to comment 3.8 PY CI tests in github config file.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION