Skip to content

feat!: bump to Python3.9#23890

Merged
villebro merged 15 commits into
apache:masterfrom
sebastianliebscher:update-python-ci
May 10, 2023
Merged

feat!: bump to Python3.9#23890
villebro merged 15 commits into
apache:masterfrom
sebastianliebscher:update-python-ci

Conversation

@sebastianliebscher
Copy link
Copy Markdown
Contributor

@sebastianliebscher sebastianliebscher commented May 1, 2023 •
edited
Loading

SUMMARY

Running CI integration and unit tests for Python 3.9 is a first step to fully upgrade official release to Python 3.10.
This PR bumps Python to version 3.9:

Also, added double quotes around strategy.matrix.python-versions values as without quotes, e.g. 3.10 is interpreted as 3.1 reference to GitHub Actions Doc

TESTING INSTRUCTIONS

All existing and new CI jobs run without errors.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 1, 2023 •
edited
Loading

Codecov Report

Merging #23890 (0e520ae) into master (7757b61) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 0e520ae differs from pull request most recent head 3b7e1f9. Consider uploading reports for the commit 3b7e1f9 to get more accurate results

@@            Coverage Diff             @@
##           master   #23890      +/-   ##
==========================================
+ Coverage   68.19%   68.21%   +0.02%     
==========================================
  Files        1941     1941              
  Lines       75277    75302      +25     
  Branches     8166     8166              
==========================================
+ Hits        51333    51371      +38     
+ Misses      21855    21842      -13     
  Partials     2089     2089
Flag Coverage Δ
hive 53.18% <ø> (+<0.01%) ⬆️
mysql 78.91% <ø> (?)
postgres 78.98% <ø> (+<0.01%) ⬆️
presto 53.09% <ø> (+<0.01%) ⬆️
python 82.75% <ø> (+0.04%) ⬆️
sqlite 77.51% <ø> (+0.01%) ⬆️
unit 53.00% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 17 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pull-request-size pull-request-size Bot added size/S and removed size/XS labels May 2, 2023
@sebastianliebscher sebastianliebscher changed the title feat: run ci unit+integration tests for py310 feat(ci): run unit+integration tests for py310 May 2, 2023
@villebro
Copy link
Copy Markdown
Member

villebro commented May 2, 2023

@sebastianliebscher is adding quotes around the python version the "correct" way? It would be nice to add a note about that in the description.

@sebastianliebscher
Copy link
Copy Markdown
Contributor Author

sebastianliebscher commented May 2, 2023 •
edited
Loading

@villebro Without the quotes, e.g. 3.10 is interpreted as 3.1. But you are right, I missed that in the desciption. I updated the desciption accordingly 👍

@villebro
Copy link
Copy Markdown
Member

villebro commented May 2, 2023

@villebro Without the quotes, e.g. 3.10 is interpreted as 3.1. But you are right, I missed that in the desciption. I updated the desciption accordingly 👍

Thanks @sebastianliebscher - makes sense 👍

@pull-request-size pull-request-size Bot added size/M and removed size/S labels May 8, 2023
@sebastianliebscher sebastianliebscher changed the title feat(ci): run unit+integration tests for py310 feat: bump Python3.9 May 9, 2023
@sebastianliebscher sebastianliebscher changed the title feat: bump Python3.9 feat: bump to Python3.9 May 9, 2023
villebro
villebro reviewed May 10, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few quick comments

Comment thread .asf.yaml Outdated
Comment thread scripts/benchmark_migration.py Outdated
@EugeneTorap EugeneTorap mentioned this pull request May 10, 2023
Merged
9 tasks
dpgaspar
dpgaspar reviewed May 10, 2023
View reviewed changes
Comment thread Dockerfile
dpgaspar
dpgaspar approved these changes May 10, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thank you @sebastianliebscher this is great!

villebro
villebro approved these changes May 10, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, exciting! 🚀 @sebastianliebscher let's rebase to restart CI

@sebastianliebscher
Copy link
Copy Markdown
Contributor Author

sebastianliebscher commented May 10, 2023

Also many thanks to @EugeneTorap, great team effort :)

@EugeneTorap EugeneTorap force-pushed the update-python-ci branch 3 times, most recently from 7b9f63f to 708b000 Compare May 10, 2023 16:13
@villebro villebro merged commit e3719a1 into apache:master May 10, 2023
@EugeneTorap EugeneTorap deleted the update-python-ci branch May 10, 2023 17:27
animesh-kumar9779 added a commit to animesh-kumar9779/superset that referenced this pull request May 10, 2023
@animesh-kumar9779
Revert "feat: bump to Python3.9 (apache#23890)"
23bb315 
This reverts commit e3719a1.
@mdeshmu mdeshmu mentioned this pull request May 12, 2023
Closed
9 tasks
@eschutho eschutho added the risk:breaking-change Issues or PRs that will introduce breaking changes label May 15, 2023
@eschutho eschutho changed the title feat: bump to Python3.9 feat!: bump to Python3.9 May 15, 2023
@eschutho
Copy link
Copy Markdown
Member

eschutho commented May 15, 2023

I marked this as a breaking change. All good for now since we can get it into the 3.0 release.

eschutho
eschutho reviewed May 15, 2023
View reviewed changes
Comment thread UPDATING.md
- [21163](https://github.com/apache/superset/pull/21163): The time grain will be decoupled from the time filter column and the time grain control will move below the X-Axis control when `GENERIC_CHART_AXES` feature flags set to `True`. The time grain will be applied on the time column in the column-like controls(x axis, dimensions) instead of the time column in the time section.
- [21284](https://github.com/apache/superset/pull/21284): The non-functional `MAX_TABLE_NAMES` config key has been removed.
- [21794](https://github.com/apache/superset/pull/21794): Deprecates the undocumented `PRESTO_SPLIT_VIEWS_FROM_TABLES` feature flag. Now for Presto, like other engines, only physical tables are treated as tables.
- [23890](https://github.com/apache/superset/pull/23890): Removes Python 3.8 support.
Copy link
Copy Markdown
Member

@eschutho eschutho May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to create a PR to update this file for 2.1, so I'll move this into Breaking Changes then.

This was referenced May 19, 2023
Merged
Merged
@michael-s-molina michael-s-molina mentioned this pull request Jun 28, 2023
Merged
9 tasks
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 First shipped in 3.0.0 labels Mar 13, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
@sebastianliebscher @EugeneTorap
feat: bump to Python3.9 (apache#23890)
0f7c1b6 
Co-authored-by: EugeneTorap <evgenykrutpro@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eschutho eschutho eschutho left review comments

@dpgaspar dpgaspar dpgaspar approved these changes

@villebro villebro villebro approved these changes

@geido geido Awaiting requested review from geido geido is a code owner

@rusackas rusackas Awaiting requested review from rusackas rusackas is a code owner

@betodealmeida betodealmeida Awaiting requested review from betodealmeida betodealmeida is a code owner

@nytai nytai Awaiting requested review from nytai nytai is a code owner

@mistercrunch mistercrunch Awaiting requested review from mistercrunch mistercrunch is a code owner

@craig-rueda craig-rueda Awaiting requested review from craig-rueda craig-rueda is a code owner

@john-bodley john-bodley Awaiting requested review from john-bodley

@kgabryje kgabryje Awaiting requested review from kgabryje kgabryje is a code owner

+1 more reviewer

@EugeneTorap EugeneTorap EugeneTorap left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels risk:breaking-change Issues or PRs that will introduce breaking changes size/M 🚢 3.0.0 First shipped in 3.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sebastianliebscher @villebro @eschutho @dpgaspar @EugeneTorap @mistercrunch