Skip to content

fix: Revert tox basepython#24124

Merged
john-bodley merged 2 commits into
masterfrom
john-bodley--fix-tox-basepython
May 19, 2023
Merged

fix: Revert tox basepython#24124
john-bodley merged 2 commits into
masterfrom
john-bodley--fix-tox-basepython

Conversation

@john-bodley
Copy link
Copy Markdown
Member

@john-bodley john-bodley commented May 18, 2023

SUMMARY

Accidentally in #24068 I merged a change which bumped the basepython in the tox.ini whilst testing locally. This PR reverts said mistake. Note that in #23890 we dropped support for Python 3.8 and thus the tox basepython should have also been bumped.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2023

Codecov Report

Merging #24124 (07a4e6b) into master (5159861) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #24124      +/-   ##
==========================================
+ Coverage   68.28%   68.30%   +0.02%     
==========================================
  Files        1952     1952              
  Lines       75432    75432              
  Branches     8191     8191              
==========================================
+ Hits        51505    51521      +16     
+ Misses      21823    21807      -16     
  Partials     2104     2104              
Flag Coverage Δ
hive 53.17% <ø> (ø)
javascript 54.70% <ø> (ø)
mysql 78.94% <ø> (?)
postgres 79.01% <ø> (+<0.01%) ⬆️
presto 53.10% <ø> (ø)
python 82.81% <ø> (+0.04%) ⬆️
sqlite 77.54% <ø> (ø)
unit 53.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@john-bodley john-bodley changed the title fix: Revert Tox basepython fix: Revert tox basepython May 18, 2023
@john-bodley john-bodley merged commit ba0bb20 into master May 19, 2023
@john-bodley john-bodley deleted the john-bodley--fix-tox-basepython branch May 19, 2023 13:40
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 First shipped in 3.0.0 labels Mar 8, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0 First shipped in 3.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants