Skip to content

chore(report): Use for/else clause#24107

Merged
john-bodley merged 1 commit into
masterfrom
john-bodley--chore-report-for-else
May 19, 2023
Merged

chore(report): Use for/else clause#24107
john-bodley merged 1 commit into
masterfrom
john-bodley--chore-report-for-else

Conversation

@john-bodley
Copy link
Copy Markdown
Member

@john-bodley john-bodley commented May 17, 2023

SUMMARY

A pretty minor cleanup utilizing the for/else clause which simplifies the code.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link
Copy Markdown

codecov Bot commented May 17, 2023

Codecov Report

Merging #24107 (ba2c685) into master (e856e35) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head ba2c685 differs from pull request most recent head 4202ddb. Consider uploading reports for the commit 4202ddb to get more accurate results

@@            Coverage Diff             @@
##           master   #24107      +/-   ##
==========================================
- Coverage   68.30%   68.29%   -0.01%     
==========================================
  Files        1952     1952              
  Lines       75432    75429       -3     
  Branches     8191     8191              
==========================================
- Hits        51521    51518       -3     
  Misses      21807    21807              
  Partials     2104     2104              
Flag Coverage Δ
hive 53.17% <ø> (+<0.01%) ⬆️
mysql 78.94% <ø> (-0.01%) ⬇️
postgres 79.01% <ø> (-0.01%) ⬇️
presto 53.10% <ø> (+<0.01%) ⬆️
python 82.81% <ø> (-0.01%) ⬇️
sqlite 77.54% <ø> (-0.01%) ⬇️
unit 53.09% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/reports/commands/execute.py 91.94% <ø> (-0.09%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@john-bodley john-bodley marked this pull request as ready for review May 17, 2023 23:11
Copy link
Copy Markdown
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The CI errors were fixed by #24114. You just need to rebase your code.

@john-bodley john-bodley force-pushed the john-bodley--chore-report-for-else branch from 9bf6b0c to 4202ddb Compare May 18, 2023 22:41
@john-bodley john-bodley merged commit 488ec02 into master May 19, 2023
@john-bodley john-bodley deleted the john-bodley--chore-report-for-else branch May 19, 2023 13:41
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 First shipped in 3.0.0 labels Mar 8, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0 First shipped in 3.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants