chore(report): Use for/else clause#24107
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24107 +/- ##
==========================================
- Coverage 68.30% 68.29% -0.01%
==========================================
Files 1952 1952
Lines 75432 75429 -3
Branches 8191 8191
==========================================
- Hits 51521 51518 -3
Misses 21807 21807
Partials 2104 2104
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
michael-s-molina
approved these changes
May 18, 2023
Member
michael-s-molina
left a comment
There was a problem hiding this comment.
LGTM. The CI errors were fixed by #24114. You just need to rebase your code.
9bf6b0c to
4202ddb
Compare
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
A pretty minor cleanup utilizing the for/else clause which simplifies the code.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
CI.
ADDITIONAL INFORMATION