Skip to content

fix(ci): remove username from owner#24114

Merged
villebro merged 1 commit into
apache:masterfrom
villebro:villebro/fix-test
May 18, 2023
Merged

fix(ci): remove username from owner#24114
villebro merged 1 commit into
apache:masterfrom
villebro:villebro/fix-test

Conversation

@villebro
Copy link
Copy Markdown
Member

SUMMARY

Fix a test that was broken due to the merge order of #24056 and #22801.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Copy Markdown
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2023

Codecov Report

Merging #24114 (5f89b77) into master (df4d16a) will increase coverage by 11.31%.
The diff coverage is n/a.

❗ Current head 5f89b77 differs from pull request most recent head 89f1495. Consider uploading reports for the commit 89f1495 to get more accurate results

@@             Coverage Diff             @@
##           master   #24114       +/-   ##
===========================================
+ Coverage   56.98%   68.30%   +11.31%     
===========================================
  Files        1952     1951        -1     
  Lines       75432    75403       -29     
  Branches     8191     8180       -11     
===========================================
+ Hits        42987    51506     +8519     
+ Misses      30341    21794     -8547     
+ Partials     2104     2103        -1     
Flag Coverage Δ
hive 53.17% <ø> (ø)
mysql 78.94% <ø> (?)
postgres 79.01% <ø> (?)
presto 53.10% <ø> (?)
python 82.81% <ø> (+23.38%) ⬆️
sqlite 77.54% <ø> (?)
unit 53.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 311 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@villebro villebro merged commit 2222073 into apache:master May 18, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 First shipped in 3.0.0 labels Mar 8, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0 First shipped in 3.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants