chore: Bump holidays to 0.28

[arkid15r]

SUMMARY

Upgrade holidays to v0.28.
Set holidays package upper bound to '<1.0'

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue: related to but may not fix a root cause of Update dependency "holidays" from ">=1.17 <18" to actual "0.28" as dependency for actual prophet 1.1.4 => using newer holidays killing superset V2.1.0 #24619
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[EugeneTorap]

Thank you!
@dpgaspar @villebro Can you review it?

[john-bodley]

Typically the upper bound should be exclusive of the next major version (assuming it follows semver notation).

[EugeneTorap]

@arkid15r Do you have the major version of holidays? If no, we can remove the upper bound or use <1.0

[arkid15r]

I believe relaxing the upper bound a bit would be the best case scenario here. I'll update the PR to use holidays>=0.28, <1.0

@john-bodley thank you for the suggestion.

[codecov]

Codecov Report

Merging #24647 (623a78a) into master (fe2c14f) will increase coverage by 8.85%.
The diff coverage is 33.04%.

❗ Current head 623a78a differs from pull request most recent head 2cbdbc0. Consider uploading reports for the commit 2cbdbc0 to get more accurate results

@@            Coverage Diff             @@
##           master   #24647      +/-   ##
==========================================
+ Coverage   58.33%   67.19%   +8.85%     
==========================================
  Files        1907     1908       +1     
  Lines       74153    74210      +57     
  Branches     8182     8186       +4     
==========================================
+ Hits        43255    49863    +6608     
+ Misses      28775    22226    -6549     
+ Partials     2123     2121       -2     

Flag	Coverage Δ
hive	?
mysql	79.42% <45.83%> (?)
postgres	79.51% <45.83%> (?)
presto	?
python	79.65% <45.83%> (+18.52%)	⬆️
sqlite	78.07% <45.83%> (?)
unit	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...frontend/src/SqlLab/components/SqlEditor/index.jsx	52.73% <0.00%> (-7.16%)	⬇️
superset-frontend/src/components/Icons/Icon.tsx	0.00% <ø> (ø)
...Filters/FilterBar/FilterControls/FilterControl.tsx	27.69% <0.00%> (-0.44%)	⬇️
...veFilters/FilterBar/FilterControls/FilterValue.tsx	5.76% <ø> (+0.10%)	⬆️
...tersConfigModal/FiltersConfigForm/DefaultValue.tsx	9.09% <0.00%> (ø)
...mponents/nativeFilters/FiltersConfigModal/utils.ts	46.96% <0.00%> (ø)
...nd/src/dashboard/components/nativeFilters/state.ts	64.28% <ø> (ø)
.../src/explore/components/ControlPanelsContainer.tsx	69.76% <0.00%> (ø)
...features/annotationLayers/AnnotationLayerModal.tsx	58.97% <ø> (ø)
...ntend/src/features/annotations/AnnotationModal.tsx	50.98% <ø> (ø)
... and 32 more

... and 340 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[EugeneTorap]

Hi @rusackas @john-bodley! Merge it?