fix: Downgrades Prophet to 1.1.1 and Holidays to 0.23#25017
Merged
michael-s-molina merged 2 commits intoAug 17, 2023
Conversation
john-bodley
approved these changes
Aug 17, 2023
michael-s-molina
added a commit
that referenced
this pull request
Aug 18, 2023
|
For me the combination prophet 1.1.4 and holidays 0.32 is working when installing it inside of a running superset 2.1.0 container. |
Contributor
Right - no issues for me. At least when installing it inside the already running container. Not sure if this makes any difference though. The pip freeze outputs holidays==0.32 and prophet==1.1.4 as part of the list. Maybe it's worth mentioning that I'm actually running a latest-dev container built with a createdAT timestamp "2023-07-20T12:20:53Z". |
9 tasks
Closed
3 tasks
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
9 tasks
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
#24129 bumped Prophet to 1.1.4 but there's a nasty bug affecting all versions following 1.1.1. This PR downgrades Prophet to 1.1.1 and pins the version in
setup.py. We can relax the version constraint once that bug is fixed.This PR also reverts the holidays bump given that version 0.28 is incompatible with
prophet1.1.1 even with a declared dependency ofholidays>=0.14.2. I tried using version 0.28 but it broke CI.TESTING INSTRUCTIONS
CI should be sufficient.
ADDITIONAL INFORMATION