Skip to content

fix(bar-chart): change legend padding for horizontal orientation#27883

Merged
lilykuang merged 1 commit into
masterfrom
bar-chart-fix-legend-padding
Apr 3, 2024
Merged

fix(bar-chart): change legend padding for horizontal orientation#27883
lilykuang merged 1 commit into
masterfrom
bar-chart-fix-legend-padding

Conversation

@lilykuang
Copy link
Copy Markdown
Member

SUMMARY

  • Bar Chart v2 Horizontal bar with temporal Y-Axis is plotted out of axis

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
bar-chart-before

After:
bar-chart

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@lilykuang lilykuang merged commit cfa0556 into master Apr 3, 2024
@rusackas rusackas deleted the bar-chart-fix-legend-padding branch April 4, 2024 01:03
@michael-s-molina michael-s-molina added v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch labels Apr 4, 2024
michael-s-molina pushed a commit that referenced this pull request Apr 4, 2024
EandrewJones pushed a commit to UMD-ARLIS/superset that referenced this pull request Apr 5, 2024
michael-s-molina pushed a commit that referenced this pull request Apr 8, 2024
EnxDev pushed a commit to EnxDev/superset that referenced this pull request Apr 12, 2024
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
@scarbeau
Copy link
Copy Markdown

@lilykuang we just upgraded and this fix appears to be causing excess padding with all our bar charts, see below.

Screenshot 2024-06-21 at 11 25 36 AM

@sfirke
Copy link
Copy Markdown
Member

sfirke commented Jun 21, 2024

@scarbeau good timing, I am experiencing this bug too and just traced it back to this PR. I will open a new issue.

@rusackas
Copy link
Copy Markdown
Member

The PR was reverted, so the new issue should be gone.

@mistercrunch mistercrunch added 🍒 3.1.3 Cherry-picked to 3.1.3 🍒 4.0.1 Cherry-picked to 4.0.1 🍒 4.0.2 Cherry-picked to 4.0.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Jul 2, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@mistercrunch mistercrunch added the 🚢 4.1.0 First shipped in 4.1.0 label Nov 27, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels plugins size/S v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch 🍒 3.1.3 Cherry-picked to 3.1.3 🍒 4.0.1 Cherry-picked to 4.0.1 🍒 4.0.2 Cherry-picked to 4.0.2 🚢 4.1.0 First shipped in 4.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants