fix(revert 27883): Excess padding in horizontal Bar charts#29345
Merged
michael-s-molina merged 2 commits intoJun 25, 2024
Conversation
michael-s-molina
requested review from
Antonio-RiveroMartnez,
lilykuang,
rusackas and
villebro
dosubot
Bot
added
viz:charts:bar
rusackas
reviewed
Jun 24, 2024
| const xAxisOffset = addXAxisTitleOffset ? Number(xAxisTitleMargin) || 0 : 0; | ||
| const showLegendTopOffset = | ||
| isHorizontal && showLegend && legendOrientation === LegendOrientation.Top | ||
| ? 100 |
Member
There was a problem hiding this comment.
Do we need to revert the whole thing, or should this 100px just be a more reasonable number?
Member
Author
There was a problem hiding this comment.
You cannot set a fixed padding because it will depend on the size of each bar generated by ECharts, which will also vary depending on the number of bars. This calculation should be done automatically by ECharts.
rusackas
changed the title
rusackas
approved these changes
Jun 24, 2024
Member
rusackas
left a comment
rusackas
left a comment
There was a problem hiding this comment.
Approving to unblock, but wondering if the fix-forward is simply changing a number.
Member
Author
michael-s-molina
added
the
v4.0
michael-s-molina
added a commit
that referenced
this pull request
Jun 26, 2024
(cherry picked from commit 708afb7)
3 tasks
9 tasks
mistercrunch
added
🍒 4.0.2
eschutho
pushed a commit
that referenced
this pull request
Jul 24, 2024
ratuldawar11
pushed a commit
to grofers/superset
that referenced
this pull request
Apr 14, 2026
* fix(permalink): adding anchor to dashboard permalink generation (apache#28744) * fix: filters not updating with force update when caching is enabled (apache#29291) (cherry picked from commit 527f1d2) * fix(sqllab): invalid empty state on switch tab (apache#29278) * fix(metastore-cache): prune before add (apache#29301) (cherry picked from commit 172ddb4) * fix: Remove recursive repr call (apache#29314) (cherry picked from commit 9444c6b) * fix: Cannot delete empty column inside a tab using the dashboard editor (apache#29346) (cherry picked from commit ee52277) * fix(explore): restored hidden field values has discarded (apache#29349) (cherry picked from commit 160cece) * chore: Rename Totals to Summary in table chart (apache#29360) * fix(revert 27883): Excess padding in horizontal Bar charts (apache#29345) (cherry picked from commit 708afb7) * fix(explore): don't respect y-axis formatting (apache#29367) * fix: adds the ability to disallow SQL functions per engine (apache#28639) * chore: Adds 4.0.2 RC2 data to CHANGELOG.md * fixes * frontend fixes * fix: cache api --------- Co-authored-by: Jack <41238731+fisjac@users.noreply.github.com> Co-authored-by: ka-weihe <k@weihe.dk> Co-authored-by: JUST.in DO IT <justin.park@airbnb.com> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> Co-authored-by: Jessie R <j@scjr.me> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: Daniel Vaz Gaspar <danielvazgaspar@gmail.com> Co-authored-by: Michael S. Molina <michael.s.molina@gmail.com>
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR reverts #27883 which incorrectly calculated the chart's padding and introduced #29342.
There's a bug with
yAxis.inversein ECharts and we don't know when a fix will be provided. To fix this issue, this PR partially reverts #23273 which introduced said configuration. I'm purposefully not adding a migration to this PR, as #23273 did, so it can be cherry-picked as it's affecting all 4.0.x versions. This will change the default y-axis order of horizontal bar charts. @yousophAn alternative solution, would be to fix the ECharts bug. @villebro
Fixes #29342
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
1 - Create an horizontal bar chart using a time column in the x-axis
2 - Check that the chart is displayed correctly.
ADDITIONAL INFORMATION