Skip to content

fix: filters not updating with force update when caching is enabled#29291

Merged
michael-s-molina merged 1 commit into
apache:masterfrom
ka-weihe:master
Jun 18, 2024
Merged

fix: filters not updating with force update when caching is enabled#29291
michael-s-molina merged 1 commit into
apache:masterfrom
ka-weihe:master

Conversation

@ka-weihe
Copy link
Copy Markdown
Contributor

@ka-weihe ka-weihe commented Jun 18, 2024

SUMMARY

Currently, when you have caching enabled and you click "refresh dashboard" it only updates the charts but not the filters. This is despite the filters having a loading spinner next to them.

TESTING INSTRUCTIONS

  1. Setup Superset with caching
  2. Create a dataset with a simple table and create any chart and add it to a dashboard. Add a filter to the dashboard - could be the values of one of the columns. Insert a new row to the table with a new value for the column you have created a filter for.
  3. Force refresh the dashboard using "refresh dashboard" in the upper right hand corner.

You will see your chart updating, but not the filter.

ADDITIONAL INFORMATION

@dosubot dosubot Bot added dashboard:native-filters Related to the native filters of the Dashboard dashboard:refresh Related to the refresh frequency of the Dashboard labels Jun 18, 2024
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

Copy link
Copy Markdown
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @ka-weihe!

Copy link
Copy Markdown
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, really great improvement!

@michael-s-molina michael-s-molina merged commit 527f1d2 into apache:master Jun 18, 2024
@michael-s-molina michael-s-molina added the v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch label Jun 18, 2024
@john-bodley john-bodley added the review:checkpoint Last PR reviewed during the daily review standup label Jun 18, 2024
@Vitor-Avila
Copy link
Copy Markdown
Contributor

This is awesome! thank you 🙏

@john-bodley john-bodley removed the review:checkpoint Last PR reviewed during the daily review standup label Jun 20, 2024
michael-s-molina pushed a commit that referenced this pull request Jun 26, 2024
@mistercrunch mistercrunch added 🍒 4.0.2 Cherry-picked to 4.0.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Jul 24, 2024
@mistercrunch mistercrunch added the 🚢 4.1.0 First shipped in 4.1.0 label Nov 27, 2024
ratuldawar11 pushed a commit to grofers/superset that referenced this pull request Apr 14, 2026
* fix(permalink): adding anchor to dashboard permalink generation (apache#28744)

* fix: filters not updating with force update when caching is enabled (apache#29291)

(cherry picked from commit 527f1d2)

* fix(sqllab): invalid empty state on switch tab (apache#29278)

* fix(metastore-cache): prune before add (apache#29301)

(cherry picked from commit 172ddb4)

* fix: Remove recursive repr call (apache#29314)

(cherry picked from commit 9444c6b)

* fix: Cannot delete empty column inside a tab using the dashboard editor (apache#29346)

(cherry picked from commit ee52277)

* fix(explore): restored hidden field values has discarded (apache#29349)

(cherry picked from commit 160cece)

* chore: Rename Totals to Summary in table chart (apache#29360)

* fix(revert 27883): Excess padding in horizontal Bar charts (apache#29345)

(cherry picked from commit 708afb7)

* fix(explore): don't respect y-axis formatting (apache#29367)

* fix: adds the ability to disallow SQL functions per engine (apache#28639)

* chore: Adds 4.0.2 RC2 data to CHANGELOG.md

* fixes

* frontend fixes

* fix: cache api

---------

Co-authored-by: Jack <41238731+fisjac@users.noreply.github.com>
Co-authored-by: ka-weihe <k@weihe.dk>
Co-authored-by: JUST.in DO IT <justin.park@airbnb.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Co-authored-by: Jessie R <j@scjr.me>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Daniel Vaz Gaspar <danielvazgaspar@gmail.com>
Co-authored-by: Michael S. Molina <michael.s.molina@gmail.com>
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:native-filters Related to the native filters of the Dashboard dashboard:refresh Related to the refresh frequency of the Dashboard size/XS v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch 🍒 4.0.2 Cherry-picked to 4.0.2 🚢 4.1.0 First shipped in 4.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Filters are not updating with force update if cache is enabled for some time

6 participants