fix(explore): restored hidden field values has discarded#29349
Merged
justinpark merged 2 commits intoJun 24, 2024
Conversation
justinpark
requested review from
betodealmeida,
eschutho,
michael-s-molina and
sfirke
dosubot
Bot
added
explore
michael-s-molina
approved these changes
Jun 24, 2024
Member
|
Thank you!!! |
rusackas
approved these changes
Jun 24, 2024
rusackas
added
the
review:checkpoint
justinpark
force-pushed
the
hotfix--hidden-control-value-discarded
branch
from
a9ad6f2 to
b705009
Compare
michael-s-molina
added
the
v4.0
john-bodley
removed
the
review:checkpoint
michael-s-molina
pushed a commit
that referenced
this pull request
Jun 26, 2024
(cherry picked from commit 160cece)
mistercrunch
added
🍒 4.0.2
eschutho
pushed a commit
that referenced
this pull request
Jul 24, 2024
ratuldawar11
pushed a commit
to grofers/superset
that referenced
this pull request
Apr 14, 2026
* fix(permalink): adding anchor to dashboard permalink generation (apache#28744) * fix: filters not updating with force update when caching is enabled (apache#29291) (cherry picked from commit 527f1d2) * fix(sqllab): invalid empty state on switch tab (apache#29278) * fix(metastore-cache): prune before add (apache#29301) (cherry picked from commit 172ddb4) * fix: Remove recursive repr call (apache#29314) (cherry picked from commit 9444c6b) * fix: Cannot delete empty column inside a tab using the dashboard editor (apache#29346) (cherry picked from commit ee52277) * fix(explore): restored hidden field values has discarded (apache#29349) (cherry picked from commit 160cece) * chore: Rename Totals to Summary in table chart (apache#29360) * fix(revert 27883): Excess padding in horizontal Bar charts (apache#29345) (cherry picked from commit 708afb7) * fix(explore): don't respect y-axis formatting (apache#29367) * fix: adds the ability to disallow SQL functions per engine (apache#28639) * chore: Adds 4.0.2 RC2 data to CHANGELOG.md * fixes * frontend fixes * fix: cache api --------- Co-authored-by: Jack <41238731+fisjac@users.noreply.github.com> Co-authored-by: ka-weihe <k@weihe.dk> Co-authored-by: JUST.in DO IT <justin.park@airbnb.com> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> Co-authored-by: Jessie R <j@scjr.me> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: Daniel Vaz Gaspar <danielvazgaspar@gmail.com> Co-authored-by: Michael S. Molina <michael.s.molina@gmail.com>
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
When the x-axis was changed back to a time item from a non-time control item, the values of hidden fields were not properly restored to their original state, causing them to be consistently recognized as hidden items and preventing form_data from being sent.
This commit fixes the issue and includes test code to prevent regression.
Fixes #29331
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
before--missing-hidden-fields.mov
After:
after--hidden-fields.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION