fix(sqllab): pass DB id instead of name#33955
Conversation
|
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment
|
1db207f to
342815d
Compare
There was a problem hiding this comment.
I've completed my review and didn't find any issues.
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/src/components/DatabaseSelector/index.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
mistercrunch
left a comment
There was a problem hiding this comment.
LGTM, trying to understand what happened here and whether we should expect more funk from the large merge. I'm the one on the git blame on master because of the "squash and merge" strategy, but I pulled the git blame from template_less and see this:
b8354785147 (Mehmet Salih Yavuz 2025-04-08 15:14:15 +0300 356)
Tagging Memo to see if he has a take on how this slip in. Guessing intricate merge conflict...
|
Updated the description to auto-close #33935, FYI. |
342815d to
f19100e
Compare
Ah, it's because it generates |
|
Seems to be working now in master. |
|
@betodealmeida could you please re-open this PR? |
|
I can confirm the bug is still happening on master. |
|
Is this fix getting merged? I do face this issue as of latest master. |
|
I need to fix the failing test. Will do it ASAP. |
|
OK, let's merge this as soon as it's green! |
|
Thanks for fixing this! 👏 |
fix(sqllab): pass DB id instead of name (apache#33955)
SUMMARY
#31590 broke SQL Lab by replacing the dbID with a name:
https://github.com/apache/superset/pull/31590/files#diff-ea7a7f3b0884ed0d868929c970403455028773ec29a90c6ef8b507d6b4e9ab34R199
This PR fixes it.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION