Skip to content

fix(sqllab): pass DB id instead of name#33955

Merged
betodealmeida merged 2 commits into
masterfrom
fix-sqllab
Jul 15, 2025
Merged

fix(sqllab): pass DB id instead of name#33955
betodealmeida merged 2 commits into
masterfrom
fix-sqllab

Conversation

@betodealmeida
Copy link
Copy Markdown
Member

@betodealmeida betodealmeida commented Jun 27, 2025

SUMMARY

#31590 broke SQL Lab by replacing the dbID with a name:

https://github.com/apache/superset/pull/31590/files#diff-ea7a7f3b0884ed0d868929c970403455028773ec29a90c6ef8b507d6b4e9ab34R199

This PR fixes it.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

@korbit-ai
Copy link
Copy Markdown

korbit-ai Bot commented Jun 27, 2025

Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment /korbit-review.

Your admin can change your review schedule in the Korbit Console

@betodealmeida betodealmeida marked this pull request as ready for review June 27, 2025 16:06
@dosubot dosubot Bot added the sqllab Namespace | Anything related to the SQL Lab label Jun 27, 2025
Copy link
Copy Markdown

@korbit-ai korbit-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Files scanned
File Path Reviewed
superset-frontend/src/components/DatabaseSelector/index.tsx

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

Copy link
Copy Markdown
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, trying to understand what happened here and whether we should expect more funk from the large merge. I'm the one on the git blame on master because of the "squash and merge" strategy, but I pulled the git blame from template_less and see this:

b8354785147 (Mehmet Salih Yavuz    2025-04-08 15:14:15 +0300 356)

Tagging Memo to see if he has a take on how this slip in. Guessing intricate merge conflict...

@rusackas
Copy link
Copy Markdown
Member

Updated the description to auto-close #33935, FYI.

@betodealmeida
Copy link
Copy Markdown
Member Author

LGTM, trying to understand what happened here and whether we should expect more funk from the large merge. I'm the one on the git blame on master because of the "squash and merge" strategy, but I pulled the git blame from template_less and see this:

b8354785147 (Mehmet Salih Yavuz    2025-04-08 15:14:15 +0300 356)

Tagging Memo to see if he has a take on how this slip in. Guessing intricate merge conflict...

Ah, it's because it generates <div id="1"/>, but an ID can't be a number. We need a better way of passing the DB ID.

@betodealmeida
Copy link
Copy Markdown
Member Author

Seems to be working now in master.

@hai-ld
Copy link
Copy Markdown

hai-ld commented Jul 2, 2025

@betodealmeida could you please re-open this PR? master doesn't work for me (as of 308007f). It only works after I apply your changes.

@michael-s-molina
Copy link
Copy Markdown
Member

I can confirm the bug is still happening on master.

@HarshithGamini
Copy link
Copy Markdown
Contributor

HarshithGamini commented Jul 9, 2025

Is this fix getting merged? I do face this issue as of latest master.

sunnykharel-spycloud
sunnykharel-spycloud approved these changes Jul 10, 2025
@betodealmeida
Copy link
Copy Markdown
Member Author

I need to fix the failing test. Will do it ASAP.

@rusackas
Copy link
Copy Markdown
Member

According to @dosu, this may fix #34130 as well.

@betodealmeida
Copy link
Copy Markdown
Member Author

OK, let's merge this as soon as it's green!

@betodealmeida betodealmeida merged commit 0dc48e9 into master Jul 15, 2025
56 checks passed
@betodealmeida betodealmeida deleted the fix-sqllab branch July 15, 2025 22:43
@betodealmeida betodealmeida mentioned this pull request Jul 15, 2025
9 tasks
@mistercrunch
Copy link
Copy Markdown
Member

Thanks for fixing this! 👏

VisaryLab pushed a commit to VisaryLab/superset that referenced this pull request Jul 18, 2025
VisaryLab pushed a commit to VisaryLab/superset that referenced this pull request Jul 18, 2025
VisaryLab added a commit to VisaryLab/superset that referenced this pull request Jul 18, 2025
fix(sqllab): pass DB id instead of name (apache#33955)
dankor pushed a commit to dankor/superset that referenced this pull request Aug 18, 2025
@github-actions github-actions Bot added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 6.0.0 First shipped in 6.0.0 labels Dec 18, 2025
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS sqllab Namespace | Anything related to the SQL Lab 🚢 6.0.0 First shipped in 6.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants