Skip to content

fix(sqllab): database ID#34181

Merged
betodealmeida merged 2 commits into
masterfrom
fix-sqllab-again
Jul 15, 2025
Merged

fix(sqllab): database ID#34181
betodealmeida merged 2 commits into
masterfrom
fix-sqllab-again

Conversation

@betodealmeida
Copy link
Copy Markdown
Member

SUMMARY

Fix that should be in #33955 instead.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Copy Markdown

@korbit-ai korbit-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Files scanned
File Path Reviewed
superset-frontend/src/components/DatabaseSelector/index.tsx

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

Copy link
Copy Markdown
Contributor

@Vitor-Avila Vitor-Avila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick follow up!

@betodealmeida betodealmeida added the merge-if-green If approved and tests are green, please go ahead and merge it for me label Jul 15, 2025
@betodealmeida betodealmeida merged commit 000d353 into master Jul 15, 2025
62 of 65 checks passed
@betodealmeida betodealmeida deleted the fix-sqllab-again branch July 15, 2025 23:37
VisaryLab pushed a commit to VisaryLab/superset that referenced this pull request Jul 18, 2025
VisaryLab added a commit to VisaryLab/superset that referenced this pull request Jul 18, 2025
dankor pushed a commit to dankor/superset that referenced this pull request Aug 18, 2025
@github-actions github-actions Bot added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 6.0.0 First shipped in 6.0.0 labels Dec 18, 2025
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels merge-if-green If approved and tests are green, please go ahead and merge it for me size/XS 🚢 6.0.0 First shipped in 6.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants