fix(Select): fix Russian translations for Select

[innovark37]

User description

User description

SUMMARY

Strings Select all and Deselect all are not extracted from Select component when following the documentation. This PR fixes missing translations for Select component.
FYI: Deselect all is translated only because ListView component uses this string.

UPD: After merging master, Deselect all was renamed to Clear in the codebase. Both Select all and Clear are now properly extracted (they're used elsewhere). However, this component still needs the fix to display translations correctly.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE

AFTER

TESTING INSTRUCTIONS

1. Add next lines to config file:

BABEL_DEFAULT_LOCALE = "ru"
LANGUAGES = {
  "ru": {"flag": "ru", "name": "Русский"},
  "en": {"flag": "us", "name": "English"}
}

2. Start the application.
3. Create dashboard.
4. Add native filter (Filter type = "Value").
5. Verify the translations in Select footer (strings Select all and Deselect all).

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

---

CodeAnt-AI Description

Fix Russian translations and footer layout for Select component

What Changed

• The Select footer now displays translated labels for "Select all" and "Clear" (Russian translations are applied correctly).
• Counts are rendered outside the translatable strings so counts no longer break or prevent translation of the labels.
• Bulk-action buttons in the Select footer can wrap to the next line to avoid layout overflow on narrow screens.

Impact

✅ Clearer Russian Select labels
✅ Fewer untranslated Select footer strings
✅ No overflow of bulk-action buttons on narrow screens

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.07%. Comparing base (c9fb1bc) to head (9ed6b0f).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #35751   +/-   ##
=======================================
  Coverage   64.07%   64.07%           
=======================================
  Files        2590     2590           
  Lines      137963   137963           
  Branches    31998    31998           
=======================================
  Hits        88406    88406           
  Misses      48039    48039           
  Partials     1518     1518           

Flag	Coverage Δ
javascript	66.99% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[codeant-ai-for-open-source]

CodeAnt AI is reviewing your PR.

---

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

[codeant-ai-for-open-source]

Nitpicks 🔍

🔒 No security issues identified

⚡ Recommended areas for review Accessibility The new buttons render the count inline but do not expose an explicit aria-label that includes the dynamic count. Screen reader users may not get the full context (action + number). Verify the buttons are announced correctly and consider providing aria-labels that include the count or an aria-live region for updates. i18n / pluralization The change separates the static label from the dynamic count (e.g. {t('Select all')} {(${bulkSelectCounts.selectable})}). While this enables extraction of the base strings, it may break correct word order or pluralization rules in languages such as Russian where the count's placement and inflection matter. Consider using a single localized message with a placeholder or pluralization support so translators can place the count appropriately. Layout change The bulk actions container gained the wrap prop (StyledBulkActionsContainer justify="center" wrap). Confirm that the styled component supports the wrap prop and that the visual change does not negatively affect compact layouts or overflow in small viewports.

[codeant-ai-for-open-source]

CodeAnt AI finished reviewing your PR.

[bito-code-review]

Code Review Agent Run #ed0c54

Actionable Suggestions - 0

Additional Suggestions - 1

• superset-frontend/packages/superset-ui-core/src/components/Select/Select.tsx - 1

  • Valid UI Prop Addition · Line 495-495
    The addition of the 'wrap' prop to StyledBulkActionsContainer is valid, as it corresponds to a supported boolean prop in the underlying Antd Flex component (used via the custom Flex wrapper). This allows flex items (the Select all and Deselect all buttons) to wrap to the next line if the container width is insufficient, improving layout responsiveness without altering existing behavior.

Review Details

• Files reviewed - 2 · Commit Range: 8846250..5d8c43c

  • superset-frontend/packages/superset-ui-core/src/components/Select/Select.tsx
  • superset/translations/ru/LC_MESSAGES/messages.po
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[codeant-ai-for-open-source]

Sequence Diagram

This PR ensures the Select component's bulk actions use properly extracted Russian translations for the Select all and Clear labels while updating selected values and notifying parent components.

sequenceDiagram
    participant User
    participant SelectComponent as Select component
    participant I18n as Translation service
    participant Parent as Parent component

    User->>SelectComponent: Open dropdown with bulk actions
    SelectComponent->>I18n: Request text for Select all and Clear
    I18n-->>SelectComponent: Return localized labels
    User->>SelectComponent: Click Select all
    SelectComponent->>SelectComponent: Compute new selected values
    SelectComponent->>Parent: Fire onChange with updated values
    User->>SelectComponent: Click Clear
    SelectComponent->>SelectComponent: Remove deselectable values
    SelectComponent->>Parent: Fire onChange with cleared values

Loading

---

Generated by CodeAnt AI

[innovark37]

@sadpandajoe @SBIN2010
Hi! This PR is still open and I'd love to move it forward. If there are any concerns or changes needed, please let me know and I'll be happy to address them. Thanks for your time!

[netlify]

✅ Deploy Preview for superset-docs-preview ready!

Name	Link
🔨 Latest commit	9ed6b0f
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/6a034cafd39fd00008ad2d6f
😎 Deploy Preview	https://deploy-preview-35751--superset-docs-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[bito-code-review]

Code Review Agent Run #40c1c0

Actionable Suggestions - 0

Review Details

• Files reviewed - 1 · Commit Range: 1e79543..43216f4

  • superset-frontend/packages/superset-ui-core/src/components/Select/Select.tsx
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[sfirke]

Hi @innovark37 sorry this has languished! I just merged a large Russian language update this morning: #39589 Could you merge the latest master into this PR? Then let's see if we can get this merged.

[sfirke]

I wonder why that sharded Jest tests (6) keeps getting cancelled. I picked a random other frontend PR, #40000, and it succeeded in 6m:

Frontend Build CI (unit tests, linting & sanity checks) / sharded-jest-tests (6) (pull_request)Successful in 6m

I would love to be 100% sure that the small changes to this one frontend file aren't causing a problem with that CI test. I will merge master in again and force the re-run.

[sfirke]

Well that was dumb, I had to re-merge master branch 4 times until CI passed? Seems flaky to me but I'll take it. Thanks @innovark37 for the fix!

[bito-code-review]

Bito Automatic Review Skipped – PR Already Merged

Bito scheduled an automatic review for this pull request, but the review was skipped because this PR was merged before the review could be run.
No action is needed if you didn't intend to review it. To get a review, you can type /review in a comment and save it