fix(i18n): update Russian translations#39589
Conversation
github-actions
Bot
added
i18n
bialkou
force-pushed
the
fix-translation
branch
from
ba8a101 to
7d90de3
Compare
![bito-code-review[bot]](https://avatars.githubusercontent.com/in/1061978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review Agent Run #85fd15
Actionable Suggestions - 2
-
superset/translations/ru/LC_MESSAGES/messages.po - 2
- Incorrect gettext flag · Line 254-254
- Incorrect gettext flag · Line 16113-16113
Additional Suggestions - 2
-
superset/translations/ru/LC_MESSAGES/messages.po - 2
-
Translation Inconsistency · Line 1596-1596The translation of 'dataset' in this error message uses 'источника данных' (data source), but elsewhere in the file 'dataset' is consistently translated as 'датасет'. This inconsistency could confuse users. Update to 'датасета' for consistency.
Code suggestion
@@ -1597,1 +1597,1 @@ - msgstr "Произошла ошибка при перезаписи источника данных" + msgstr "Произошла ошибка при перезаписи датасета"
-
Incorrect python-format flag · Line 4354-4354The msgid "Default datetime column" does not contain any Python string formatting placeholders (e.g., %s, %d), so the `python-format` flag is incorrect and should be removed. This prevents potential issues with gettext validation tools that check for flag consistency.
-
Review Details
-
Files reviewed - 1 · Commit Range:
7d90de3..7d90de3- superset/translations/ru/LC_MESSAGES/messages.po
-
Files skipped - 0
-
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide
Commands
Type the following command in the pull request comment and save the comment.
-
/review- Manually triggers a full AI review. -
/pause- Pauses automatic reviews on this pull request. -
/resume- Resumes automatic reviews. -
/resolve- Marks all Bito-posted review comments as resolved. -
/abort- Cancels all in-progress reviews.
Refer to the documentation for additional commands.
Configuration
This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.
Documentation & Help
AI Code Review powered by
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #39589 +/- ##
=======================================
Coverage 63.88% 63.88%
=======================================
Files 2583 2583
Lines 136596 136596
Branches 31501 31501
=======================================
Hits 87271 87271
Misses 47809 47809
Partials 1516 1516
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@bialkou Thanks for this PR! I would be happy to review and approve. Could you please respond to those comments from Bito the AI code review tool? |
Co-authored-by: bito-code-review[bot] <188872107+bito-code-review[bot]@users.noreply.github.com>
Co-authored-by: bito-code-review[bot] <188872107+bito-code-review[bot]@users.noreply.github.com>
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@sfirke Thanks! I addressed the Bito review comments and pushed the fixes |
sfirke
left a comment
sfirke
left a comment
There was a problem hiding this comment.
Spot-checked with Kagi Translate. Some of the old translations were pretty bad! Looks like a nice improvement.
I see the comment "Не переводить" = "Do not translate" -- I was surprised to see it only in Russian at first but I think it's fine and it's nice that you noted that it was intentionally left blank.
|
Bito Automatic Review Skipped – PR Already Merged |
Co-authored-by: bito-code-review[bot] <188872107+bito-code-review[bot]@users.noreply.github.com>
Co-authored-by: bito-code-review[bot] <188872107+bito-code-review[bot]@users.noreply.github.com>
2 participants
SUMMARY
Updates Russian translations in
superset/translations/ru/LC_MESSAGES/messages.po, including corrected labels/messages, completed missing strings, and removal of obsolete fuzzy markers.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Not applicable; translation-only change.
TESTING INSTRUCTIONS
msgfmt --check superset/translations/ru/LC_MESSAGES/messages.po -o /tmp/superset-ru-messages.mouvx pre-commit run --all-fileswas run before pushing. It failed on unrelated mypy errors in existing test files (tests/unit_tests/mcp_service/chart/validation/test_column_name_normalization.py,tests/unit_tests/mcp_service/chart/test_chart_schemas.py,tests/unit_tests/commands/importers/v1/assets_test.py). The remaining long prettier pass was stopped after that unrelated failure to avoid carrying unrelated auto-format changes.ADDITIONAL INFORMATION