Autocomplete in the table browser in SQL lab is broken#7736
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7736 +/- ##
=========================================
Coverage ? 65.78%
=========================================
Files ? 459
Lines ? 21925
Branches ? 2410
=========================================
Hits ? 14424
Misses ? 7380
Partials ? 121
Continue to review full report at Codecov.
|
Member
|
Awesome! |
betodealmeida
pushed a commit
that referenced
this pull request
Jun 21, 2019
mistercrunch
added
🏷️ bot
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
* fix: explicitly provide value and label strings * fix: spacing
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
…e#7736)" (apache#7743) * Revert "Autocomplete in the table browser in SQL lab is broken (apache#7736)" This reverts commit 7139d8d. * Kick off build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
The autocomplete in the table browser in SQL lab does not work. We use the createFilterOptions API from the react-select-fast-filter-options library for autocomplete. The API expects a list of option objects where its properties value and label are strings. The bug is that we were passing objects to the property value, which caused the algorithm to not work properly. Now we explicitly pass strings to the API.
TEST PLAN
Manually verified
REVIEWERS
@betodealmeida @DiggidyDave @xtinec