Revert "Autocomplete in the table browser in SQL lab is broken (#7736)"

[khtruong]

Accidentally broke connecting to tables after searching. Reverting this change.

This reverts commit d1b81e0.

REVIEWERS

@betodealmeida @DiggidyDave @xtinec

[betodealmeida]

+1

[betodealmeida]

Looks like the backend should return the tables in a standardized format, and it's not?

[etr2460]

Lgtm

[codecov-io]

Codecov Report

Merging #7743 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #7743      +/-   ##
==========================================
- Coverage   65.78%   65.75%   -0.03%     
==========================================
  Files         459      459              
  Lines       21925    21924       -1     
  Branches     2410     2410              
==========================================
- Hits        14424    14417       -7     
- Misses       7380     7386       +6     
  Partials      121      121

Impacted Files	Coverage Δ
superset/assets/src/components/TableSelector.jsx	84.67% <100%> (-0.13%)	⬇️
superset/db_engine_specs/sqlite.py	45.83% <0%> (-20.84%)	⬇️
superset/utils/core.py	87.93% <0%> (-0.18%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1b81e0...9cde95e. Read the comment docs.

[villebro]

I believe the observed bug has its origins in changes introduced by #7453, which changes table names from strings to dicts/objects:

• Before: tables were strings of format 'my_table' or 'my_schema.my_table'
• Now: { schema: 'my_schema', table: 'my_table' }

The change was done because many engines support periods in the object names, which confused the frontend. However, apparently there were side-effects that were not covered by unit tests. If having tables in object format causes problems, one solution could be to make them strings again, but make sure periods in object names are properly escaped.