-
Notifications
You must be signed in to change notification settings - Fork 113
Enhancing Report Generation by Adding Operator Json and Comments Section #2807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbai00
reviewed
Aug 31, 2024
core/gui/src/app/workspace/service/report-generation/report-generation.service.ts
Show resolved
Hide resolved
core/gui/src/app/workspace/service/report-generation/report-generation.service.ts
Show resolved
Hide resolved
core/gui/src/app/workspace/service/report-generation/report-generation.service.ts
Outdated
Show resolved
Hide resolved
bobbai00
approved these changes
Aug 31, 2024
Contributor
bobbai00
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
chenlica
reviewed
Aug 31, 2024
Contributor
chenlica
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my comments.
core/gui/src/app/workspace/service/report-generation/report-generation.service.ts
Outdated
Show resolved
Hide resolved
core/gui/src/app/workspace/service/report-generation/report-generation.service.ts
Outdated
Show resolved
Hide resolved
f69f5b8 to
d740a8c
Compare
Contributor
|
Now the PR looks good. |
This was referenced Sep 17, 2024
xudongwu-0
added a commit
that referenced
this pull request
Sep 18, 2024
This PR enhances the report generation functionality by adding animation during the process. This PR is a continuation and enhancement of the previous PR: Adding a button to generate a report for a workflow: #2770 Enhancing Report Generation by adding Operator Results: #2792 Enhancing Report Generation by Adding Operator Json and Comments Section : #2807 Ai Flag: #2818 and #2808 Key Changes: **menu.component.ts:** At the start, notification.blank is called to display a message, and notification.remove is used to remove it at the end. Upon successful generation, this.notificationService.success is invoked. **notification.service.ts:** notification.blank and notification.remove have been added. Screenshot of the notification:  
xudongwu-0
added a commit
that referenced
this pull request
Oct 15, 2024
#2816) This PR enhances the report generation functionality by addingStory-teller Ai based on Ai flag. This PR is a continuation and enhancement of the previous PR: Adding a button to generate a report for a workflow: #2770 Enhancing Report Generation by adding Operator Results: #2792 Enhancing Report Generation by Adding Operator Json and Comments Section : #2807 Ai Flag: #2818 and #2808 **New Methods:** checkAiAssistantEnabled(): Validates whether the AI Assistant feature is enabled by checking the availability of the required API key. This function ensures that subsequent AI-based functionalities are executed only when the AI Assistant is available. generateComment(operatorInfo: any): Generates insightful comments for each operator using OpenAI’s GPT model, tailored for a highly educated audience but one that might not have deep statistical knowledge. The comments are plain text, enhancing the overall readability and value of the report. generateSummaryComment(operatorInfo: any): Produces a concise, insightful summary comment that highlights key findings, trends, and areas of improvement across the workflow, focusing particularly on UDFs. This function is crucial for providing a comprehensive understanding of the workflow to users. **Enhanced Methods:** retrieveOperatorInfoReport(operatorId: string, allResults: { operatorId: string; html: string }[]): Implements the checkAiAssistantEnabled, generateComment, and generateSummaryComment functions to enrich the operator information section in the generated reports. The function now adds a "Toggle Detail" button beneath each operator, allowing users to expand and view the operator’s corresponding JSON, formatted using a JSON viewer. Additionally, a comments section is added below each operator, enabling users to leave or view AI-generated comments. generateReportAsHtml(workflowSnapshot: string, allResults: string[], workflowName: string): Generates a comprehensive HTML file containing the workflow snapshot, all operator results, operator details, and comments. This method integrates AI-generated comments and a summary section at the end of the report. It also introduces a "Download Workflow JSON" button, allowing users to download the entire workflow JSON file directly from the report. **Operation Process:** Click the button below to generate the report with detailed operator results and the workflow snapshot.  To turn on the ai feature, you need to modify the following sections in application.udf  For example, to turn on the openai:  Here is a part of the example report.  
PurelyBlank
pushed a commit
that referenced
this pull request
Dec 4, 2024
…ion (#2807) This PR enhances the report generation functionality by adding Operator JSON and Comments Section. This PR is a continuation and enhancement of the previous PR, which can be found at the following link: #2770 and #2792 1. The file was modified in this PR: ReportGenerationService retrieveOperatorInfoReport(operatorId: string,allResults: { operatorId: string; html: string }[]): Implements a 'Toggle Detail' button beneath each operator, allowing users to expand and view the operator's corresponding JSON, formatted using a JSON viewer. Adds a comments section below each operator, enabling users to leave their own comments. It can be use 2. generateReportAsHtml(workflowSnapshot: string, allResults: string[], workflowName: string): Generates a comprehensive HTML file containing the workflow snapsho, all operator results, operator details, and comments section ,then triggers a download of the report. add 'Download Workflow JSON' button, allowing user download the whole JSON file directly from the report. Operation Process: Click the button below to generate the report with detailed operator results and the workflow snapshot.  Here is a part of the example report.  
PurelyBlank
pushed a commit
that referenced
this pull request
Dec 4, 2024
This PR enhances the report generation functionality by adding animation during the process. This PR is a continuation and enhancement of the previous PR: Adding a button to generate a report for a workflow: #2770 Enhancing Report Generation by adding Operator Results: #2792 Enhancing Report Generation by Adding Operator Json and Comments Section : #2807 Ai Flag: #2818 and #2808 Key Changes: **menu.component.ts:** At the start, notification.blank is called to display a message, and notification.remove is used to remove it at the end. Upon successful generation, this.notificationService.success is invoked. **notification.service.ts:** notification.blank and notification.remove have been added. Screenshot of the notification:  
PurelyBlank
pushed a commit
that referenced
this pull request
Dec 4, 2024
#2816) This PR enhances the report generation functionality by addingStory-teller Ai based on Ai flag. This PR is a continuation and enhancement of the previous PR: Adding a button to generate a report for a workflow: #2770 Enhancing Report Generation by adding Operator Results: #2792 Enhancing Report Generation by Adding Operator Json and Comments Section : #2807 Ai Flag: #2818 and #2808 **New Methods:** checkAiAssistantEnabled(): Validates whether the AI Assistant feature is enabled by checking the availability of the required API key. This function ensures that subsequent AI-based functionalities are executed only when the AI Assistant is available. generateComment(operatorInfo: any): Generates insightful comments for each operator using OpenAI’s GPT model, tailored for a highly educated audience but one that might not have deep statistical knowledge. The comments are plain text, enhancing the overall readability and value of the report. generateSummaryComment(operatorInfo: any): Produces a concise, insightful summary comment that highlights key findings, trends, and areas of improvement across the workflow, focusing particularly on UDFs. This function is crucial for providing a comprehensive understanding of the workflow to users. **Enhanced Methods:** retrieveOperatorInfoReport(operatorId: string, allResults: { operatorId: string; html: string }[]): Implements the checkAiAssistantEnabled, generateComment, and generateSummaryComment functions to enrich the operator information section in the generated reports. The function now adds a "Toggle Detail" button beneath each operator, allowing users to expand and view the operator’s corresponding JSON, formatted using a JSON viewer. Additionally, a comments section is added below each operator, enabling users to leave or view AI-generated comments. generateReportAsHtml(workflowSnapshot: string, allResults: string[], workflowName: string): Generates a comprehensive HTML file containing the workflow snapshot, all operator results, operator details, and comments. This method integrates AI-generated comments and a summary section at the end of the report. It also introduces a "Download Workflow JSON" button, allowing users to download the entire workflow JSON file directly from the report. **Operation Process:** Click the button below to generate the report with detailed operator results and the workflow snapshot.  To turn on the ai feature, you need to modify the following sections in application.udf  For example, to turn on the openai:  Here is a part of the example report.  
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the report generation functionality by adding Operator JSON and Comments Section. This PR is a continuation and enhancement of the previous PR, which can be found at the following link: #2770 and #2792
retrieveOperatorInfoReport(operatorId: string,allResults: { operatorId: string; html: string }[]):
Implements a 'Toggle Detail' button beneath each operator, allowing users to expand and view the operator's corresponding JSON, formatted using a JSON viewer.
Adds a comments section below each operator, enabling users to leave their own comments. It can be use
Generates a comprehensive HTML file containing the workflow snapsho, all operator results, operator details, and comments section ,then triggers a download of the report.
add 'Download Workflow JSON' button, allowing user download the whole JSON file directly from the report.
Operation Process: Click the button below to generate the report with detailed operator results and the workflow snapshot.

Here is a part of the example report.

