Add notification when report is generating #2843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbai00
reviewed
Sep 18, 2024
Contributor
bobbai00
left a comment
bobbai00
left a comment
There was a problem hiding this comment.
Left 2 comments. Great job!
core/gui/src/app/common/service/notification/notification.service.ts
Outdated
Show resolved
Hide resolved
bobbai00
changed the title
bobbai00
changed the title
bobbai00
approved these changes
Sep 18, 2024
core/gui/src/app/common/service/notification/notification.service.ts
Outdated
Show resolved
Hide resolved
core/gui/src/app/common/service/notification/notification.service.ts
Outdated
Show resolved
Hide resolved
PurelyBlank
pushed a commit
that referenced
this pull request
Dec 4, 2024
This PR enhances the report generation functionality by adding animation during the process. This PR is a continuation and enhancement of the previous PR: Adding a button to generate a report for a workflow: #2770 Enhancing Report Generation by adding Operator Results: #2792 Enhancing Report Generation by Adding Operator Json and Comments Section : #2807 Ai Flag: #2818 and #2808 Key Changes: **menu.component.ts:** At the start, notification.blank is called to display a message, and notification.remove is used to remove it at the end. Upon successful generation, this.notificationService.success is invoked. **notification.service.ts:** notification.blank and notification.remove have been added. Screenshot of the notification:  
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the report generation functionality by adding animation during the process. This PR is a continuation and enhancement of the previous PR:
Adding a button to generate a report for a workflow: #2770
Enhancing Report Generation by adding Operator Results: #2792
Enhancing Report Generation by Adding Operator Json and Comments Section : #2807
Ai Flag: #2818 and #2808
Key Changes:
menu.component.ts:
At the start, notification.blank is called to display a message, and notification.remove is used to remove it at the end. Upon successful generation, this.notificationService.success is invoked.
notification.service.ts:
notification.blank and notification.remove have been added.
Screenshot of the notification:
