Add a download button for the binary type data from the result panel #2855
Conversation
aglinxinyuan
left a comment
aglinxinyuan
left a comment
There was a problem hiding this comment.
Overall, it looks good to me. I recommend removing the button's box border and retaining only the icon for a cleaner appearance.
|
I thought the frontend binary format was changed to a shorter format.. (e.g., |
@Yicong-Huang The PR only introduces the download button and doesn't affect the binary format in the result panel. It seems there might be some confusion with the RowModalComponent, which displays 
|
Got it. Such a format should be applied to the table view as well. But that's to be done in another PR. Thanks for the explanation! |
I'll quickly create a separate PR to do so! |
…nel with Improved UI (#2869) This PR builds upon the improvements made in PR #2855. Previously, the download button was limited to binary values in the result panel. However, users may also want to download other types of data, such as long strings, which were not supported in the previous implementation. Key Improvements: - Users can now download any value from the result panel, providing greater flexibility. - This change removes the restriction of downloading only binary data. - To maintain a clean and user-friendly interface, the download button is now hidden by default and will appear when the user hovers over a row. This prevents the UI from becoming cluttered with download buttons in every table cell. https://github.com/user-attachments/assets/e060894e-bd65-4646-8b67-d85585b171d4 --------- Co-authored-by: Kunwoo Park <kunwoopark@Kunwoos-MacBook-Pro.local> Co-authored-by: Xinyuan Lin <xinyual3@uci.edu>
…2855) This PR introduces a "Download" button for binary data in the result panel, which becomes available when the result table contains binary type data. #### User Experience: - When the user clicks the "Download" button, a result exportation modal will appear. - The modal includes an additional input field where the user can specify a filename for the binary data. - A default filename is suggested in the format: [columnName]_[rowNumber], but the user has the option to modify it as desired. - The rest of the modal is similar to the existing result exportation: the user selects a dataset as the destination and clicks the "Save" button to store the file. This enhancement streamlines the handling of binary data exports, making the process more intuitive and user-friendly. <img width="1065" alt="Screenshot 2024-09-22 at 9 58 07 PM" src="https://github.com/user-attachments/assets/0b5620c7-0e41-41b7-9652-8e977edb339f"> https://github.com/user-attachments/assets/19e31782-bd90-405b-b09e-44ffc314d488 --------- Co-authored-by: Kunwoo Park <kunwoopark@Kunwoos-MacBook-Pro.local> Co-authored-by: Kunwoo Park <kunwoopark@dhcp-172-31-184-236.mobile.uci.edu> Co-authored-by: Xinyuan Lin <xinyual3@uci.edu>
…nel with Improved UI (#2869) This PR builds upon the improvements made in PR #2855. Previously, the download button was limited to binary values in the result panel. However, users may also want to download other types of data, such as long strings, which were not supported in the previous implementation. Key Improvements: - Users can now download any value from the result panel, providing greater flexibility. - This change removes the restriction of downloading only binary data. - To maintain a clean and user-friendly interface, the download button is now hidden by default and will appear when the user hovers over a row. This prevents the UI from becoming cluttered with download buttons in every table cell. https://github.com/user-attachments/assets/e060894e-bd65-4646-8b67-d85585b171d4 --------- Co-authored-by: Kunwoo Park <kunwoopark@Kunwoos-MacBook-Pro.local> Co-authored-by: Xinyuan Lin <xinyual3@uci.edu>
3 participants
This PR introduces a "Download" button for binary data in the result panel, which becomes available when the result table contains binary type data.
User Experience:
This enhancement streamlines the handling of binary data exports, making the process more intuitive and user-friendly.
Screen.Recording.2024-09-20.at.1.51.46.PM.mov