Skip to content

Conversation

@kunwp1
Copy link
Contributor

@kunwp1 kunwp1 commented Sep 24, 2024

This PR builds upon the improvements made in PR #2855. Previously, the download button was limited to binary values in the result panel. However, users may also want to download other types of data, such as long strings, which were not supported in the previous implementation.

Key Improvements:

  • Users can now download any value from the result panel, providing greater flexibility.
  • This change removes the restriction of downloading only binary data.
  • To maintain a clean and user-friendly interface, the download button is now hidden by default and will appear when the user hovers over a row. This prevents the UI from becoming cluttered with download buttons in every table cell.
Screen.Recording.2024-09-24.at.9.48.39.AM.mov

@kunwp1 kunwp1 added feature frontend Changes related to the frontend GUI labels Sep 24, 2024
@kunwp1 kunwp1 requested a review from aglinxinyuan September 24, 2024 16:49
@kunwp1 kunwp1 self-assigned this Sep 24, 2024
Copy link
Contributor

@aglinxinyuan aglinxinyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better!

@kunwp1 kunwp1 merged commit 2d7837a into master Sep 25, 2024
@kunwp1 kunwp1 deleted the chris-add-download-to-all-cells branch September 25, 2024 02:24
PurelyBlank pushed a commit that referenced this pull request Dec 4, 2024
…nel with Improved UI (#2869)

This PR builds upon the improvements made in PR #2855. Previously, the
download button was limited to binary values in the result panel.
However, users may also want to download other types of data, such as
long strings, which were not supported in the previous implementation.

Key Improvements:
- Users can now download any value from the result panel, providing
greater flexibility.
- This change removes the restriction of downloading only binary data.
- To maintain a clean and user-friendly interface, the download button
is now hidden by default and will appear when the user hovers over a
row. This prevents the UI from becoming cluttered with download buttons
in every table cell.


https://github.com/user-attachments/assets/e060894e-bd65-4646-8b67-d85585b171d4

---------

Co-authored-by: Kunwoo Park <kunwoopark@Kunwoos-MacBook-Pro.local>
Co-authored-by: Xinyuan Lin <xinyual3@uci.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature frontend Changes related to the frontend GUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants