Consistent string format of the binary data #2863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yicong-Huang
approved these changes
Sep 23, 2024
Contributor
Yicong-Huang
left a comment
Yicong-Huang
left a comment
There was a problem hiding this comment.
LGTM in general, left comments about null values.
.../src/app/workspace/component/result-panel/result-table-frame/result-table-frame.component.ts
Outdated
Show resolved
Hide resolved
kunwp1
added a commit
that referenced
this pull request
Sep 24, 2024
This PR addresses an issue introduced in PR #2863, where non-string values (e.g., integers, longs) containing only 0 or 1 were incorrectly identified as binary data in the frontend and displayed as such. This fix ensures that non-string values are now correctly handled and displayed according to their actual type, preventing them from being mistakenly rendered as binary data. [Before] <img width="1034" alt="Screenshot 2024-09-24 at 11 30 12 AM" src="https://github.com/user-attachments/assets/f300334c-8df0-4d99-a65f-b05c50816b7e"> [After] <img width="1032" alt="Screenshot 2024-09-24 at 11 30 40 AM" src="https://github.com/user-attachments/assets/dd34ec19-74ac-4b99-b05a-0730d2ea16e1"> Co-authored-by: Kunwoo Park <kunwoopark@Kunwoos-MacBook-Pro.local>
PurelyBlank
pushed a commit
that referenced
this pull request
Dec 4, 2024
This PR ensures consistency between the result panel and the `RowModalComponent` when displaying binary data. Previously, the result panel showed a trimmed string, while the `RowModalComponent` displayed a trimmed string with a "byte" prefix when a user clicked on a single row in the table. With this update, both components will now display the same trimmed string, improving the user experience by maintaining consistent data presentation across the interface. <img width="1147" alt="Screenshot 2024-09-23 at 10 12 00 AM" src="https://github.com/user-attachments/assets/700e22e0-7537-4916-a724-1aff159cbcbc"> --------- Co-authored-by: Kunwoo Park <kunwoopark@Kunwoos-MacBook-Pro.local>
PurelyBlank
pushed a commit
that referenced
this pull request
Dec 4, 2024
This PR addresses an issue introduced in PR #2863, where non-string values (e.g., integers, longs) containing only 0 or 1 were incorrectly identified as binary data in the frontend and displayed as such. This fix ensures that non-string values are now correctly handled and displayed according to their actual type, preventing them from being mistakenly rendered as binary data. [Before] <img width="1034" alt="Screenshot 2024-09-24 at 11 30 12 AM" src="https://github.com/user-attachments/assets/f300334c-8df0-4d99-a65f-b05c50816b7e"> [After] <img width="1032" alt="Screenshot 2024-09-24 at 11 30 40 AM" src="https://github.com/user-attachments/assets/dd34ec19-74ac-4b99-b05a-0730d2ea16e1"> Co-authored-by: Kunwoo Park <kunwoopark@Kunwoos-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures consistency between the result panel and the
RowModalComponentwhen displaying binary data. Previously, the result panel showed a trimmed string, while theRowModalComponentdisplayed a trimmed string with a "byte" prefix when a user clicked on a single row in the table. With this update, both components will now display the same trimmed string, improving the user experience by maintaining consistent data presentation across the interface.