Skip to content

Conversation

@kunwp1
Copy link
Contributor

@kunwp1 kunwp1 commented Sep 24, 2024

This PR addresses an issue introduced in PR #2863, where non-string values (e.g., integers, longs) containing only 0 or 1 were incorrectly identified as binary data in the frontend and displayed as such. This fix ensures that non-string values are now correctly handled and displayed according to their actual type, preventing them from being mistakenly rendered as binary data.

[Before]

Screenshot 2024-09-24 at 11 30 12 AM

[After]
Screenshot 2024-09-24 at 11 30 40 AM

@kunwp1 kunwp1 added fix frontend Changes related to the frontend GUI labels Sep 24, 2024
@kunwp1 kunwp1 requested a review from Yicong-Huang September 24, 2024 18:31
@kunwp1 kunwp1 self-assigned this Sep 24, 2024
Copy link
Contributor

@Yicong-Huang Yicong-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kunwp1 kunwp1 merged commit 411d88c into master Sep 24, 2024
@kunwp1 kunwp1 deleted the chris-fix-issue-display-integer branch September 24, 2024 18:46
PurelyBlank pushed a commit that referenced this pull request Dec 4, 2024
This PR addresses an issue introduced in PR #2863, where non-string
values (e.g., integers, longs) containing only 0 or 1 were incorrectly
identified as binary data in the frontend and displayed as such. This
fix ensures that non-string values are now correctly handled and
displayed according to their actual type, preventing them from being
mistakenly rendered as binary data.

[Before]

<img width="1034" alt="Screenshot 2024-09-24 at 11 30 12 AM"
src="https://github.com/user-attachments/assets/f300334c-8df0-4d99-a65f-b05c50816b7e">

[After]
<img width="1032" alt="Screenshot 2024-09-24 at 11 30 40 AM"
src="https://github.com/user-attachments/assets/dd34ec19-74ac-4b99-b05a-0730d2ea16e1">

Co-authored-by: Kunwoo Park <kunwoopark@Kunwoos-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix frontend Changes related to the frontend GUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants