Add dao to the micro-services #2960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbai00
force-pushed
the
jiadong-add-dao-micro-services
branch
from
c6d00d5 to
3fd7536
Compare
Contributor
Yicong-Huang
left a comment
Yicong-Huang
left a comment
There was a problem hiding this comment.
- remove resources, remove codegen, remove config.
- change package name to dao.
- change the SQLServer to take parameters.
- let util/codeGen generate to this codebase.
core/micro-services/dao/src/main/scala/edu/uci/ics/texera/SqlServer.java
Outdated
Show resolved
Hide resolved
Yicong-Huang
approved these changes
Oct 25, 2024
core/micro-services/dao/src/main/scala/edu/uci/ics/texera/dao/SqlServer.scala
Outdated
Show resolved
Hide resolved
bobbai00
added a commit
that referenced
this pull request
Nov 2, 2024
PurelyBlank
pushed a commit
that referenced
this pull request
Dec 4, 2024
This PR adds `dao` to the `micro-services`. ### Dependency in the micro-services No dependencies. ### What items does it have `dao` stands for database object. It contains - jooq code generator, written in `core/micro-services/dao/src/main/scala/edu/uci/ics/texera/JooqCodeGeneration.java`, come from `core/util/src/main/java/edu/uci/ics/util/RunCodegen.java` - SqlServer which is used to connect the DB, written in `core/micro-services/dao/src/main/scala/edu/uci/ics/texera/SqlServer.java`, come from `core/amber/src/main/scala/edu/uci/ics/texera/web/SqlServer.java` - `texera_ddl.sql` and all database update script, putted in `core/micro-services/dao/src/main/resources/sql`, come from `core/scripts/sql`
PurelyBlank
pushed a commit
that referenced
this pull request
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
daoto themicro-services.Dependency in the micro-services
No dependencies.
What items does it have
daostands for database object. It containscore/micro-services/dao/src/main/scala/edu/uci/ics/texera/JooqCodeGeneration.java, come fromcore/util/src/main/java/edu/uci/ics/util/RunCodegen.javacore/micro-services/dao/src/main/scala/edu/uci/ics/texera/SqlServer.java, come fromcore/amber/src/main/scala/edu/uci/ics/texera/web/SqlServer.javatexera_ddl.sqland all database update script, putted incore/micro-services/dao/src/main/resources/sql, come fromcore/scripts/sql