Skip to content

Conversation

@Yicong-Huang
Copy link
Contributor

@Yicong-Huang Yicong-Huang commented Nov 29, 2025

What changes were proposed in this PR?

Removed official support for R-UDF. The frontend is not changed, but during execution user will receive an error about unofficially supported R-UDF. We plan to move the R-UDF to a third party hosted repo, so users can install the R-UDF support as a plugin.

Any related issues, documentation, discussions?

This change was due to the fact that R-UDF runtime requires rpy2, which is not apache-license friendly.
resolves #4084

How was this PR tested?

Added test suite TestExecutorManager.

Was this PR authored or co-authored using generative AI tooling?

Tests generated by Cursor.

@github-actions github-actions bot added feature engine python ci changes related to CI labels Nov 29, 2025
@Yicong-Huang Yicong-Huang changed the title chore: drop support for RUDF chore: Drop Runtime Support for RUDF Nov 29, 2025
@Yicong-Huang Yicong-Huang changed the title chore: Drop Runtime Support for RUDF chore: Drop Runtime Support for R-UDF Nov 29, 2025
@Yicong-Huang Yicong-Huang self-assigned this Nov 29, 2025
@chenlica chenlica requested review from kunwp1 and removed request for chenlica November 29, 2025 04:18
@chenlica
Copy link
Contributor

@kunwp1 @bobbai00 please review this important change. After that, we will invite @pjfanning to review it as well.

Copy link
Contributor

@kunwp1 kunwp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chenlica chenlica requested a review from pjfanning November 29, 2025 17:23
Copy link
Contributor

@bobbai00 bobbai00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Yicong-Huang
Copy link
Contributor Author

if all good, I suggest we merge it. @chenlica

@chenlica chenlica merged commit 034cf7c into main Dec 6, 2025
10 checks passed
@chenlica chenlica deleted the feat/drop-support-for-r-udf branch December 6, 2025 04:47
bobbai00 added a commit that referenced this pull request Dec 8, 2025
### What changes were proposed in this PR?

This PR removes the `WITH_R_SUPPORT` build argument and all R-related
installation logic from the Docker build configuration:

1. **Dockerfiles** (`computing-unit-master.dockerfile` and
`computing-unit-worker.dockerfile`):
   - Removed `ARG WITH_R_SUPPORT` build argument
   - Removed conditional R runtime dependencies installation
   - Removed R compilation and installation steps (R 4.3.3)
   - Removed R packages installation (arrow, coro, dplyr)
   - Removed `LD_LIBRARY_PATH` environment variable for R libraries
   - Removed `r-requirements.txt` copy in worker dockerfile
   - Simplified to Python-only dependencies

2. **GitHub Actions Workflow**
(`.github/workflows/build-and-push-images.yml`):
   - Removed `with_r_support` workflow input parameter
   - Removed `with_r_support` from job outputs and parameter passing
- Removed `WITH_R_SUPPORT` build args from both AMD64 and ARM64 build
steps
   - Removed R Support from build summary

### Any related issues, documentation, discussions?

Related to #4090

### How was this PR tested?

Verified Dockerfile & CI yml syntax are valid

### Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Sonnet 4.5 (claude-sonnet-4-5-20250929) via Claude
Code CLI
chenlica pushed a commit that referenced this pull request Jan 20, 2026
)

<!--
Thanks for sending a pull request (PR)! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
[Contributing to
Texera](https://github.com/apache/texera/blob/main/CONTRIBUTING.md)
  2. Ensure you have added or run the appropriate tests for your PR
  3. If the PR is work in progress, mark it a draft on GitHub.
  4. Please write your PR title to summarize what this PR proposes, we 
    are following Conventional Commits style for PR titles as well.
  5. Be sure to keep the PR description updated to reflect all changes.
-->

### What changes were proposed in this PR?
<!--
Please clarify what changes you are proposing. The purpose of this
section
is to outline the changes. Here are some tips for you:
  1. If you propose a new API, clarify the use case for a new API.
  2. If you fix a bug, you can clarify why it is a bug.
  3. If it is a refactoring, clarify what has been changed.
  3. It would be helpful to include a before-and-after comparison using 
     screenshots or GIFs.
  4. Please consider writing useful notes for better and faster reviews.
-->

This PR integrates the `texera-rudf` plugin and enables R UDF operators
when the plugin is installed in the runtime environment.

Previously, #4090 removed runtime support for R UDF operators due to
licensing constraints. Following the design proposed in #4155, we now
manage all R UDF–related code in a separate repository and have the
Texera main repository consume it as an optional plugin.

For prerequisites and installation instructions, please refer to the
`README.md` in the plugin repository:
https://github.com/kunwp1/texera-rudf.
Note: This repository is currently a prototype under my personal
account. Once this PR is merged, I plan to transfer it to the Texera
organization.

### Any related issues, documentation, discussions?
<!--
Please use this section to link other resources if not mentioned
already.
1. If this PR fixes an issue, please include `Fixes #1234`, `Resolves
#1234`
or `Closes #1234`. If it is only related, simply mention the issue
number.
  2. If there is design documentation, please add the link.
  3. If there is a discussion in the mailing list, please add the link.
-->
Discussion: #4155 
PR: #4090, #4124

### How was this PR tested?
<!--
If tests were added, say they were added here. Or simply mention that if
the PR
is tested with existing test cases. Make sure to include/update test
cases that
check the changes thoroughly including negative and positive cases if
possible.
If it was tested in a way different from regular unit tests, please
clarify how
you tested step by step, ideally copy and paste-able, so that other
reviewers can
test and check, and descendants can verify in the future. If tests were
not added,
please describe why they were not added and/or why it was difficult to
add.
-->
Tested with this workflow
[Test.json](https://github.com/user-attachments/files/24662090/Test.json)

#### Plugin Uninstalled
<img width="1728" height="1117" alt="Screenshot 2026-01-15 at 9 27
17 PM"
src="https://github.com/user-attachments/assets/838ddfbc-507d-4961-8edf-8f6f2941effd"
/>

#### Plugin Installed
<img width="1728" height="1117" alt="Screenshot 2026-01-15 at 9 29
51 PM"
src="https://github.com/user-attachments/assets/57074c3a-fac4-4b3c-9578-9038e066d18d"
/>


### Was this PR authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this
PR,
please include the phrase: 'Generated-by: ' followed by the name of the
tool
and its version. If no, write 'No'. 
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for
details.
-->
No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Separate rpy2 dependency from releases due to GPL license incompatibility

4 participants