-
Notifications
You must be signed in to change notification settings - Fork 113
feat(amber): Enable R UDF Runtime via Optional texera-rudf Plugin #4164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Ma77Ball Can you review this PR? |
|
@kunwp1 I tested and validated the PR locally and confirmed they work. Overall, the PR looks good. I left a few comments above for discussion. |
amber/src/main/python/core/architecture/managers/executor_manager.py
Outdated
Show resolved
Hide resolved
amber/src/main/python/core/architecture/managers/executor_manager.py
Outdated
Show resolved
Hide resolved
amber/src/main/python/core/architecture/managers/test_executor_manager.py
Show resolved
Hide resolved
|
@Ma77Ball I addressed all your comments. Can you do one more pass and leave a comment once you're finished? Thanks! |
|
LGTM! @chenlica, please also review and approve if everything looks good. |
chenlica
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rely on the review of @Ma77Ball .
What changes were proposed in this PR?
This PR integrates the
texera-rudfplugin and enables R UDF operators when the plugin is installed in the runtime environment.Previously, #4090 removed runtime support for R UDF operators due to licensing constraints. Following the design proposed in #4155, we now manage all R UDF–related code in a separate repository and have the Texera main repository consume it as an optional plugin.
For prerequisites and installation instructions, please refer to the
README.mdin the plugin repository: https://github.com/kunwp1/texera-rudf.Note: This repository is currently a prototype under my personal account. Once this PR is merged, I plan to transfer it to the Texera organization.
Any related issues, documentation, discussions?
Discussion: #4155
PR: #4090, #4124
How was this PR tested?
Tested with this workflow Test.json
Plugin Uninstalled
Plugin Installed
Was this PR authored or co-authored using generative AI tooling?
No