/servers/{{ID}}/deliveryservices returns incorrect response for the requested API version

[ocket8888]

I'm submitting a ...

• bug report

Traffic Control components affected ...

• Traffic Ops

Current behavior:

Making a request to /servers/{{ID}}/deliveryservices will return a different structure from a request made to /deliveryservices for the same API version. As these are not the same endpoint, there's technically no reason they need to return the same structural representation for the same Delivery Service at the same API version, but because released API versions were retroactively changed to return extra fields, this is a regression bug. In fixing it, I suggest we define the response structure to be isomorphic to /deliveryservices.

The various API versions requested for /servers/{{ID}}/deliveryservices compared to the API version of /deliveryservices that would yield the same structure as /servers/{{ID}}/deliveryservices are given below:

/servers/{{ID}}/deliveryservices version	/deliveryservices version
4.0	4.0
3.1	4.0
3.0	4.0
2.0	4.0
1.5	4.0
1.4	4.0
1.3	4.0
1.2	4.0
1.1	4.0

Expected behavior:

The structure of a response from /servers/{{ID}}/deliveryservices should be the same as that of a response from /deliveryservices for the same API version. In other words, instead of the behavior described by the above table, what I'd expect to see is something more like:

/servers/{{ID}}/deliveryservices version	/deliveryservices version
4.0	4.0
3.1	3.1
3.0	3.0
2.0	2.0
1.5	1.5
1.4	1.4
1.3	1.3
1.2	1.2
1.1	1.1

Minimal reproduction of the problem with instructions:

Make requests to /servers/{{ID}}/deliveryservices, note the presence or absence of fields introduced or removed in various API versions of /deliveryservices and their presence or absence from /servers/{{ID}}/deliveryservices.