This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Per-Delivery Service TLS versions#5922
Merged
rawlinp merged 34 commits intoapache:masterfrom Jul 8, 2021
Merged
Conversation
rawlinp
suggested changes
Jun 8, 2021
ocket8888
force-pushed
the
to/ds-tls-versions
branch
8 times, most recently
from
940348b to
9b9966d
Compare
rawlinp
suggested changes
Jun 15, 2021
ocket8888
force-pushed
the
to/ds-tls-versions
branch
3 times, most recently
from
7d21dac to
d9c4278
Compare
ocket8888
force-pushed
the
to/ds-tls-versions
branch
from
5d0ffdb to
535c572
Compare
rawlinp
added
new feature
ocket8888
force-pushed
the
to/ds-tls-versions
branch
from
4368246 to
5d2fd27
Compare
rawlinp
suggested changes
Jun 30, 2021
Contributor
rawlinp
left a comment
rawlinp
left a comment
There was a problem hiding this comment.
One minor issue but otherwise looks good to go
ocket8888
force-pushed
the
to/ds-tls-versions
branch
2 times, most recently
from
caf920b to
7954470
Compare
rawlinp
suggested changes
Jul 8, 2021
Contributor
rawlinp
left a comment
rawlinp
left a comment
There was a problem hiding this comment.
unit test failure:
--- FAIL: TestReadGetDeliveryServices (0.00s)
deliveryservices_test.go:418: Unexpected system error reading Delivery Services: getting delivery services: sql: expected 69 destination arguments in Scan, not 70
FAIL
FAIL github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/deliveryservice 2.138s
TO API test failure:
--- FAIL: TestDeliveryServices (10.10s)
--- FAIL: TestDeliveryServices/TLS_Versions_property (0.01s)
deliveryservices_test.go:2457: Unexpected error creating a Delivery Service: error requesting Traffic Ops: path 'https://localhost:30443/api/4.0/deliveryservices' gave HTTP error 400 Bad Request - error-level alerts: invalid request: 'regionalGeoBlocking' is required, 'active' is required, 'dscp' is required, 'geoLimit' is required, 'geoProvider' is required, 'logsEnabled' is required, type fields: 'ipv6RoutingEnabled' is required if type is 'HTTP' - alerts: {Alerts:[{Text:invalid request: 'regionalGeoBlocking' is required, 'active' is required, 'dscp' is required, 'geoLimit' is required, 'geoProvider' is required, 'logsEnabled' is required, type fields: 'ipv6RoutingEnabled' is required if type is 'HTTP' Level:error}]}
FAIL
7954470 to
7b0b015
Compare
Previously, it would return APIv3.1 structures for API version 1.5, 2.0, 3.0, 3.1, and 4.0 (as well as unrecognized versions). It now returns the appropriate version structures for each requested version. This fixes apache#5891
…ssibly insecure version sets
…delivery services
This breaks parsing when the API endpoints that use this data change from our custom format to RFC3339.
That function is now a method of a Delivery Service, which means the call signatures of various functions in the github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/deliveryservice package no longer need to be changed.
rawlinp
approved these changes
Jul 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
This PR adds a new field to Delivery Services:
tlsVersions. This allows users to specify the versions of TLS which should be allowable for clients retrieving Delivery Service content.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Make sure the new tests pass, and that none of the old ones are broken.
The following criteria are ALL met by this PR