Invalid query param in TP (DS type)

[mitchell852]

This Bug Report affects these Traffic Control components:

• Traffic Portal

Current behavior:

When you navigate to a delivery service page in TP, the URL looks like this:

https://tp.domain.tld/#!/delivery-services/11424?type=DNS

The delivery service type is passed to the ds page via a URL query param (?type=DNS) so the proper DS form can be displayed. The problem exists when you navigate away from that page. I.e. to

https://tp.domain.tld/#!/delivery-services/11424/servers?type=DNS

^^ the query param follows you around which causes the "bug". On that page the query param will be used to apply a filter to the servers table. This is not what the user intended.

Expected behavior:

The ?type=[DS type] query param should only be programattically set when navigating to:

https://tp.domain.tld/#!/delivery-services/11424/servers?type=DNS

Steps to reproduce:

1. Navigate to a DS. i.e. https://tp.domain.tld/#!/delivery-services/11424/servers?type=DNS
2. Navigate to another page from #1. i.e. click "More > Manage Servers"
3. Notice the [DS] type query param has followed you and now has a different impact.

[mitchell852]

my recommendation would be just to change the query param name to something that won't collide with a table property. i.e.:

https://tp.domain.tld/#!/delivery-services/11424?dsType=DNS

and fix all the places that were previously keying off of type (for the ds type)