This repository was archived by the owner on Nov 24, 2025. It is now read-only.
TP: changes query param that dictates ds form template from type to dsType#6910
Merged
ocket8888 merged 1 commit intoapache:masterfrom Jun 24, 2022
Merged
TP: changes query param that dictates ds form template from type to dsType#6910ocket8888 merged 1 commit intoapache:masterfrom
ocket8888 merged 1 commit intoapache:masterfrom
Conversation
mitchell852
added
bug
ocket8888
reviewed
Jun 18, 2022
Contributor
ocket8888
left a comment
ocket8888
left a comment
There was a problem hiding this comment.
why change the parameter name instead of just removing entirely from places where it's not needed?
Member
Author
not sure where it's not needed :) i'm just trying to eliminate the parameter clashing and afaik it's "needed" in all those places where it's defined...the problem is the URL query param tends to follow you around to other pages where it's "not needed" and when it does, it clashes with other "type" query params |
ocket8888
approved these changes
Jun 24, 2022
Contributor
ocket8888
left a comment
ocket8888
left a comment
There was a problem hiding this comment.
This does fix the bug.
zrhoffman
pushed a commit
to zrhoffman/trafficcontrol
that referenced
this pull request
Oct 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #6909
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist