Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Fix TO cdns/dnsseckeys to default if no ttl exists#3206

Merged
elsloo merged 1 commit intoapache:masterfrom
rob05c:to-fix-dnsseckeys-no-param
Jan 18, 2019
Merged

Fix TO cdns/dnsseckeys to default if no ttl exists#3206
elsloo merged 1 commit intoapache:masterfrom
rob05c:to-fix-dnsseckeys-no-param

Conversation

@rob05c
Copy link
Copy Markdown
Member

@rob05c rob05c commented Jan 11, 2019

Fixes #3204

API Tests don't support Riak yet.
Manually Tested against a TO environment with Riak, with DNSSEC keys. Deleted the tld.ttls.DS and Snapshotted the CDN, verified an Internal Server Error without this fix, endpoint works as expected and logs errors with the fix.

What does this PR do?

Fixes #3204

Which TC components are affected by this PR?

  • Documentation
  • Grove
  • Traffic Analytics
  • Traffic Monitor
  • Traffic Ops
  • Traffic Ops ORT
  • Traffic Portal
  • Traffic Router
  • Traffic Stats
  • Traffic Vault
  • Other _________

What is the best way to verify this PR?

On a TO deployment with DNSSEC and Riak, delete the tld.ttls.DS Parameter and Snapshot the CRConfig for the CDN. Without this PR, /api/1.4/cdns/name/{cdn-name}/dnsseckeys will return an Internal Server Error, with this PR, endpoint will succeed.

Check all that apply

  • This PR includes tests
  • This PR includes documentation updates
  • This PR includes an update to CHANGELOG.md
  • This PR includes all required license headers
  • This PR includes a database migration (ensure that migration sequence is correct)
  • This PR fixes a serious security flaw. Read more: www.apache.org/security

@rob05c rob05c added bug something isn't working as intended Traffic Ops related to Traffic Ops WIP "Work-in-Progress" - do not merge! (use 'draft' pull requests from now on) labels Jan 11, 2019
@rob05c rob05c changed the title Fix TO cdns/dnsseckeys to default if no ttl exists WIP Fix TO cdns/dnsseckeys to default if no ttl exists Jan 11, 2019
@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Jan 11, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3037/
Test PASSed.

@rob05c rob05c removed the WIP "Work-in-Progress" - do not merge! (use 'draft' pull requests from now on) label Jan 11, 2019
@rob05c rob05c changed the title WIP Fix TO cdns/dnsseckeys to default if no ttl exists Fix TO cdns/dnsseckeys to default if no ttl exists Jan 11, 2019
@elsloo elsloo self-assigned this Jan 18, 2019
@elsloo elsloo merged commit e156e7a into apache:master Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug something isn't working as intended Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Traffic Ops /api/1.4/cdns/name/{name}/dnsseckeys returns 500 if Snapshot or DS TTL Parameter doesn't exist

3 participants