This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix TO cdns/dnsseckeys to default if no ttl exists#3206
Merged
elsloo merged 1 commit intoapache:masterfrom Jan 18, 2019
Merged
Conversation
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3204
API Tests don't support Riak yet.
Manually Tested against a TO environment with Riak, with DNSSEC keys. Deleted the
tld.ttls.DSand Snapshotted the CDN, verified an Internal Server Error without this fix, endpoint works as expected and logs errors with the fix.What does this PR do?
Fixes #3204
Which TC components are affected by this PR?
What is the best way to verify this PR?
On a TO deployment with DNSSEC and Riak, delete the
tld.ttls.DSParameter and Snapshot the CRConfig for the CDN. Without this PR,/api/1.4/cdns/name/{cdn-name}/dnsseckeyswill return anInternal Server Error, with this PR, endpoint will succeed.Check all that apply