This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix Traffic Ops /dnsseckeys/ksk/generate when no ksk exists#3205
Merged
elsloo merged 3 commits intoapache:masterfrom Jan 18, 2019
Merged
Fix Traffic Ops /dnsseckeys/ksk/generate when no ksk exists#3205elsloo merged 3 commits intoapache:masterfrom
elsloo merged 3 commits intoapache:masterfrom
Conversation
rob05c
added
new feature
rob05c
changed the title
rob05c
added
the
WIP
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
rob05c
force-pushed
the
to-fix-ksk-gen-when-no-existing
branch
from
c1bd35d to
a0017fc
Compare
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
rob05c
force-pushed
the
to-fix-ksk-gen-when-no-existing
branch
from
a0017fc to
7f80c8d
Compare
rob05c
removed
the
WIP
rob05c
changed the title
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
Fixes apache#3204 (cherry picked from commit a494466)
This reverts commit cc25418.
rob05c
force-pushed
the
to-fix-ksk-gen-when-no-existing
branch
from
7f80c8d to
a46a2b1
Compare
17 tasks
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3153
TO API Tests don't support Riak yet.
Manually tested against a TO with Riak. Creating a new CDN with DNSSEC enabled, then calling
/cdns/{name}/dnsseckeys/ksk/generateworks, and generates a new KSK as expected.This also incidentally fixes
/cdns/dnsseckeys/generatefor a brand-new CDN.Note for these endpoints to work with a newly created CDN, it will require a DS TTL on a Router Profile, without #3206 .
What does this PR do?
Fixes #3153
Which TC components are affected by this PR?
What is the best way to verify this PR?
Create a new CDN, then call /cdns/{name}/dnsseckeys/ksk/generate . Verify keys were created by calling and inspecting
/api/1.4/cdns/name/{name}/dnsseckey.Note for these endpoints to work with a newly created CDN, it will require a DS TTL on a Router Profile, without #3206 .
The easiest way to verify this, is to also apply #3206 and then verify that a brand-new CDN can generate dnsseckeys and ksks.
Also verify /cdns/{name}/dnsseckeys/ksk/generate and /cdns/dnsseckeys/generate still work appropriately for existing CDNs: call those endpoints on an existing CDN with existing DNSSEC keys and KSKs, and verify existing keys are updated with new times correctly, and previous keys are changed to "expired" status.
Check all that apply