This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Interfaces first migration#4635
Merged
mattjackson220 merged 5 commits intoapache:masterfrom May 5, 2020
Merged
Conversation
ocket8888
added
new feature
shamrickus
suggested changes
Apr 15, 2020
shamrickus
approved these changes
Apr 15, 2020
Member
shamrickus
left a comment
shamrickus
left a comment
There was a problem hiding this comment.
LGTM
- No weasel issues
- DB can be migrated and rolled back
- Data appears to be properly seeded from existing data.
- Design matches BP
Contributor
Author
|
This isn't ready to merge yet, my company has some production data that includes subnets in gateways, which under this model is not allowed. So I'm waiting to hear back about their usage and necessity. |
Contributor
Author
|
Okay, it was determined those are probably mistakes, so I added some logic to strip them on upgrades. Plus I fixed a check constraint to properly consider mask length based on address family. |
ocket8888
force-pushed
the
interfaces-first-migration
branch
from
f1a2e53 to
48f0d7d
Compare
ocket8888
force-pushed
the
interfaces-first-migration
branch
from
48f0d7d to
5bf6301
Compare
Contributor
|
Looks good! creates / inserts successfully, reverts successfully, old data is unchanged |
mitchell852
pushed a commit
that referenced
this pull request
May 7, 2020
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run a fresh installation of Traffic Ops and the database, verify that the new tables exist.
Run the migration against a database with existing data, verify that tables are properly populated and nothing old is mutated.
The following criteria are ALL met by this PR