This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Revert "Interfaces first migration"#4686
Merged
mitchell852 merged 1 commit intomasterfrom May 7, 2020
Merged
Conversation
This reverts commit 8c14cc8.
mitchell852
added
the
database
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it turns out, management IP values had no validation. Which means that they can't, in general, be trivially copied into the new fields that do have validation. So the plan here is to remove the old migration, then re-introduce basically the same thing but without inserting the management data.
This also has some design implications for multi-interface servers, which will be noted on the affected issues.