This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Deliveryservice Topologies#4692
Merged
ocket8888 merged 21 commits intoapache:masterfrom May 27, 2020
Merged
Conversation
rawlinp
added
new feature
…d with a ds, not just the ones explicitly assigned to a ds. i.e. the mids too to paint a better picture of which servers are employed either explicitly (edges and orgs) or implicitly (mids).
rawlinp
force-pushed
the
deliveryservice-topologies
branch
from
adb1f6c to
bacb7a1
Compare
rawlinp
added
WIP
rawlinp
removed
the
WIP
zrhoffman
suggested changes
May 18, 2020
zrhoffman
suggested changes
May 18, 2020
zrhoffman
approved these changes
May 18, 2020
Member
zrhoffman
left a comment
zrhoffman
left a comment
There was a problem hiding this comment.
TO API tests pass, TO unit tests pass, gofmt does not change the formatting of files changed in this PR, and the docs build without warnings related to this PR and look good.
The Traffic Portal portion of this PR also needs to be reviewed.
7 tasks
ocket8888
reviewed
May 21, 2020
Contributor
ocket8888
left a comment
ocket8888
left a comment
There was a problem hiding this comment.
I left all of my DS form comments on the DNS template - but they (probably mostly) apply to all of them
zrhoffman
reviewed
May 26, 2020
| <li role="menuitem"><a ng-click="viewCharts()">View Charts</a></li> | ||
| <hr class="divider"/> | ||
| <li role="menuitem"><a ng-click="viewServers()">Manage Servers</a></li> | ||
| <li ng-if="::(!deliveryService.topology)" role="menuitem"><a ng-click="viewServers()">Manage Servers</a></li> |
Member
There was a problem hiding this comment.
IMO these should be !(deliveryservice.Topology instanceof Object)
Contributor
There was a problem hiding this comment.
Nah
const a = {topology: "test"};
console.log(a.topology instanceof Object); // false
Member
There was a problem hiding this comment.
Oh, that's just the name. typeof deliveryService.Topology !== 'string' in that case
Contributor
There was a problem hiding this comment.
But then you could have
const a = {topology: ""};
console.log(typeof a.topology === "string"); //true
Member
There was a problem hiding this comment.
True, the loose comparison is useful in this case.
ocket8888
approved these changes
May 27, 2020
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Add a new
Topologyfield to Delivery Services in TO API 3.0 in order to assign Delivery Services to Topologies.topologyfield #4569Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
The following criteria are ALL met by this PR