Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Made admin user compliant with restrictions (API and TP)#4764

Merged
rawlinp merged 4 commits intoapache:masterfrom
ocket8888:add-email
Jun 8, 2020
Merged

Made admin user compliant with restrictions (API and TP)#4764
rawlinp merged 4 commits intoapache:masterfrom
ocket8888:add-email

Conversation

@ocket8888
Copy link
Copy Markdown
Contributor

What does this PR (Pull Request) do?

  • This PR is not related to any Issue

Added an email and full name to the "admin" user created for CDN-in-a-Box, and changes its password to meet the minimum length requirement. Currently in CDN-in-a-Box, if you navigate to the "admin" user's user under "Users", you notice that it's missing the required "Full Name" field and the required "Email" field, and its password isn't long enough. This means that any small change you want to make to the user e.g. for testing purposes must minimally fix those three issues. After this PR, those would no longer be a problem.

Again, though, this does change the CiaB "admin" user's password. People using CiaB for testing may be broken, but if done properly by sourcing variables.env and using $TO_ADMIN_PASSWORD it shouldn't make a difference.

Which Traffic Control components are affected by this PR?

  • CDN in a Box

What is the best way to verify this PR?

Build and run CDN-in-a-Box; everything should work normally. Try authenticating as $TO_ADMIN_USER using $TO_ADMIN_PASSWORD and verify that works. Check that user's information to verify that the email and full name are present.

The following criteria are ALL met by this PR

  • CiaB has no tests
  • Interface doesn't change so docs are unchanged
  • An update to CHANGELOG.md is not necessary
  • This PR includes any and all required license headers
  • This PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

@ocket8888 ocket8888 added low impact affects only a small portion of a CDN, and cannot itself break one cdn-in-a-box related to the Docker-based CDN-in-a-Box system improvement The functionality exists but it could be improved in some way. labels Jun 8, 2020
Comment thread infrastructure/cdn-in-a-box/traffic_ops/adduser.pl Outdated
Comment thread infrastructure/cdn-in-a-box/traffic_ops/adduser.pl Outdated
Copy link
Copy Markdown
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Confirmed CDN-in-a-Box starts successfully and readiness container exits successfully after cURLing delivery service example URLs
  • Confirmed that the admin user has the given full name and email

@rawlinp rawlinp merged commit 281b50e into apache:master Jun 8, 2020
@ocket8888 ocket8888 deleted the add-email branch June 8, 2020 21:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cdn-in-a-box related to the Docker-based CDN-in-a-Box system improvement The functionality exists but it could be improved in some way. low impact affects only a small portion of a CDN, and cannot itself break one

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants