Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Use "twelve" as the password where "twelve12" was used#7149

Open
zrhoffman wants to merge 1 commit intoapache:masterfrom
zrhoffman:twelve
Open

Use "twelve" as the password where "twelve12" was used#7149
zrhoffman wants to merge 1 commit intoapache:masterfrom
zrhoffman:twelve

Conversation

@zrhoffman
Copy link
Copy Markdown
Member

#4764 changed the default password in some places, but not all, from twelve to twelve12. This is confusing for all of the people who are used to twelve being the default password for all components of the project. This PR reverts all instances of twelve12 to twelve.


Which Traffic Control components are affected by this PR?

  • CDN in a Box
  • CDN in a Box for Developers
  • Traffic Portal
  • Traffic Portal v2

What is the best way to verify this PR?

Verify the tests pass

PR submission checklist

@zrhoffman zrhoffman added Traffic Portal v1 related to Traffic Portal version 1 tests related to tests and/or testing infrastructure cdn-in-a-box related to the Docker-based CDN-in-a-Box system improvement The functionality exists but it could be improved in some way. dev-ciab Related to CDN in a Box for Developers Traffic Portal v2 Related to the experimental Traffic Portal version 2 labels Oct 19, 2022
@zrhoffman zrhoffman mentioned this pull request Oct 19, 2022
4 tasks
@ocket8888
Copy link
Copy Markdown
Contributor

I don't agree that we should knowingly use invalid data in any environment, except in a test to ensure such data is rejected by the API.

@mitchell852
Copy link
Copy Markdown
Member

mitchell852 commented Nov 28, 2023

how about using password as the password? that meets the 8 character requirement. this is just used for cdn in a box, right?

@zrhoffman
Copy link
Copy Markdown
Member Author

I don't agree that we should knowingly use invalid data in any environment, except in a test to ensure such data is rejected by the API.

twelve12 is in invalid_passwords.txt (as is twelve), it would be rejected by the API. But using twelve12 detracts from usability, and keeping twelve does not.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 28, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.64%. Comparing base (7a3e1e0) to head (e2ebbce).
⚠️ Report is 181 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #7149       +/-   ##
=============================================
+ Coverage     28.96%   65.64%   +36.68%     
  Complexity       98       98               
=============================================
  Files           602      323      -279     
  Lines         77452    12836    -64616     
  Branches         90      970      +880     
=============================================
- Hits          22432     8426    -14006     
+ Misses        52926     4050    -48876     
+ Partials       2094      360     -1734     
Flag Coverage Δ
golib_unit ?
grove_unit ?
t3c_unit ?
traffic_monitor_unit ?
traffic_ops_unit ?
traffic_portal_v2 74.35% <100.00%> (?)
traffic_stats_unit ?
unit_tests 74.35% <100.00%> (+48.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ocket8888
Copy link
Copy Markdown
Contributor

If twelve12 would be rejected by the API then it shouldn't be in use either. It does, at least, meet the requirements in TP(v1), but really we should have a password that will be accepted. Like twelve12! (I hope; I didn't check).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cdn-in-a-box related to the Docker-based CDN-in-a-Box system dev-ciab Related to CDN in a Box for Developers improvement The functionality exists but it could be improved in some way. tests related to tests and/or testing infrastructure Traffic Portal v1 related to Traffic Portal version 1 Traffic Portal v2 Related to the experimental Traffic Portal version 2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants