Docker files for CentOS 8 build for 4.1.x#5137
Docker files for CentOS 8 build for 4.1.x#5137hbeatty wants to merge 1 commit intoapache:4.1.xfrom hbeatty:HB-cos8-docker-build-files
Conversation
|
Should this be targeted towards the master branch instead of 4.1.x? |
jhg03a
left a comment
jhg03a
left a comment
There was a problem hiding this comment.
Overall looks good, the Golang version and COS_VERSION defaults are the main things I see. I do wonder though if/what the impact is on the pkg script though since it's still the primary means of building. Before it gets merged, we'd need to be sure existing calls to pkg work and an arg and environment var can switch COS_VERSION too. It may also be worth a separate discussion about increasing our testing images + CIAB to support Centos8 as well. As long as Centos7 is the default and pkg works the same though, I'm ok with that being completely separate.
| RUN curl -LO https://dl.google.com/go/go1.14.2.linux-amd64.tar.gz && \ | ||
| tar -C /usr/local -xvzf go1.14.2.linux-amd64.tar.gz && \ | ||
| ln -s /usr/local/go/bin/go /usr/bin/go && \ | ||
| rm go1.14.2.linux-amd64.tar.gz | ||
|
|
There was a problem hiding this comment.
There were some recent modifications to upgrade to Golang 15
| RUN curl -LO https://dl.google.com/go/go1.14.2.linux-amd64.tar.gz && \ | ||
| tar -C /usr/local -xvzf go1.14.2.linux-amd64.tar.gz && \ | ||
| ln -s /usr/local/go/bin/go /usr/bin/go && \ | ||
| rm go1.14.2.linux-amd64.tar.gz |
There was a problem hiding this comment.
There were some recent modifications to upgrade to Golang 15
| RUN curl -LO https://dl.google.com/go/go1.14.2.linux-amd64.tar.gz && \ | ||
| tar -C /usr/local -xvzf go1.14.2.linux-amd64.tar.gz && \ | ||
| ln -s /usr/local/go/bin/go /usr/bin/go && \ | ||
| rm go1.14.2.linux-amd64.tar.gz |
There was a problem hiding this comment.
There were some recent modifications to upgrade to Golang 15
| RUN curl -LO https://dl.google.com/go/go1.14.2.linux-amd64.tar.gz && \ | ||
| tar -C /usr/local -xvzf go1.14.2.linux-amd64.tar.gz && \ | ||
| ln -s /usr/local/go/bin/go /usr/bin/go && \ | ||
| rm go1.14.2.linux-amd64.tar.gz |
There was a problem hiding this comment.
There were some recent modifications to upgrade to Golang 15
| RUN curl -LO https://dl.google.com/go/go1.14.2.linux-amd64.tar.gz && \ | ||
| tar -C /usr/local -xvzf go1.14.2.linux-amd64.tar.gz && \ | ||
| ln -s /usr/local/go/bin/go /usr/bin/go && \ | ||
| rm go1.14.2.linux-amd64.tar.gz |
There was a problem hiding this comment.
There were some recent modifications to upgrade to Golang 15
| RUN curl -LO https://dl.google.com/go/go1.14.2.linux-amd64.tar.gz && \ | ||
| tar -C /usr/local -xvzf go1.14.2.linux-amd64.tar.gz && \ | ||
| ln -s /usr/local/go/bin/go /usr/bin/go && \ | ||
| rm go1.14.2.linux-amd64.tar.gz |
There was a problem hiding this comment.
There were some recent modifications to upgrade to Golang 15
| traffic_monitor_build: | ||
| image: traffic_monitor_builder | ||
| build: | ||
| dockerfile: infrastructure/docker/build/Dockerfile-traffic_monitor-${COS_VERSION} |
There was a problem hiding this comment.
Might be a good idea to have a default COS_VERSION specified for 7. Docker variable intepolation should support this.
|
|
||
| ### | ||
|
|
||
| ADD infrastructure/docker/build/clean_build.sh / |
There was a problem hiding this comment.
On master this script was moved to build/clean_build.sh
zrhoffman
added
build
4 participants
I have been working on getting TC running on CentOS 8. I thought some others might be interested in these files.