This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Support CentOS 8 RPMs#5320
Merged
ocket8888 merged 12 commits intoapache:masterfrom Dec 1, 2020
Merged
Conversation
zrhoffman
added
new feature
zrhoffman
force-pushed
the
centos-8-rpms
branch
from
3c50462 to
a90fa7c
Compare
ocket8888
reviewed
Dec 1, 2020
- Make CentOS 7 the default build target - Make CentOS 8 the default build target for CDN in a Box
zrhoffman
force-pushed
the
centos-8-rpms
branch
from
2442dfd to
0d0ddb9
Compare
Member
Author
|
Rebased to fix merge conflicts |
ocket8888
pushed a commit
that referenced
this pull request
Dec 2, 2020
* CENTOS_VERSION -> RHEL_VERSION * Put help text in a here document * Sort flags * Optionally build or pull Docker builder images * - Support building RPMs that target CentOS 8 - Make CentOS 7 the default build target - Make CentOS 8 the default build target for CDN in a Box * Uncomment build section * Install common dependencies in common-dependencies build stage * Install git and rpm-build as common dependencies * Explicitly install rsync, as CentOS 7 makes rsync a git dependency but CentOS 8 does not * Upgrade builder images to CentOS 8 * Mark RHEL_VERSION for export if it is undefined * Remove commented out line Co-authored-by: Hank Beatty <hank.beatty@cox.com> (cherry picked from commit c0126fc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
This PR builds off of @hbeatty's CentOS 8 progress from #5137.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Check that Traffic Control works with RPMs built on and targeting CentOS 8
Check that Traffic Control works with RPMs built on and targeting CentOS 7
export RHEL_VERSION=7 make build-builders -j6 docker-compose build --parallel docker-compose upThe following criteria are ALL met by this PR
Additional Information
Note that only Go-based projects contain binaries that
elfdepschecks the linking for. The Go binaries have been statically linked since #4758, so that check does not find any dynamic section in the binaries, and we can use CentOS 8 builders to build RPMs targeting either CentOS 7 (the default for now) or CentOS 8.