This repository was archived by the owner on Nov 24, 2025. It is now read-only.
add t3c-tail sub-app#6960
Merged
rob05c merged 33 commits intoapache:masterfrom Aug 23, 2022
Merged
Conversation
ocket8888
added
new feature
rob05c
suggested changes
Jul 18, 2022
Member
rob05c
left a comment
rob05c
left a comment
There was a problem hiding this comment.
Looks good! All my requests are pretty minor.
This is a great feature for t3c, thanks!
ocket8888
added
the
low impact
rob05c
approved these changes
Aug 23, 2022
Member
rob05c
left a comment
rob05c
left a comment
There was a problem hiding this comment.
LGTM. Code looks good, tested, t3c-apply runs and works as expected
This was referenced Aug 25, 2022
zrhoffman
pushed a commit
to zrhoffman/trafficcontrol
that referenced
this pull request
Oct 2, 2022
* Added t3c-tail binary to t3c build * added tail to command list * Initial add * moved tail config struct t3cutil * Added t3c-tail binary to t3c build * added tail to command list * Initial add * moved tail config struct t3cutil * changes to matching for exit * added filed for ending tail before timeout is reached * added call to t3c-tail for reload and restart * added doTail func to run t3c-tail * updated README documentation * updated timeout for ats reload * added regex for end match * Changed ending matches for restart and reload * switched from sleep to timer and added logging * added variables for matching * strip datetime from diags log messages * added changelog entry * fixed formatting issues * fixed one more formating issue * fixed typo * moved must compile outside of func, use flags instead of stdin * changed and renamed timeout vars to MS, updated diags log to relative path * removed struct that is no longer needed/used * updated to use flags instead of stdin * updated to reflect changes. * fixed formatting errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the sub-app t3c-tail which can be used to tail a file, usually a log file. Reads json input from stdin. will mainly be used by t3c-apply to watch diags.log after trafficserver restart or reload. it can be useful to see what happened in diags.log without having to tail the file in a separate window. this will also be logged with the t3c log output.
Which Traffic Control components are affected by this PR?
t3c, formerly ORT)What is the best way to verify this PR?
Build Traffic Control Cache Config and install. run t3c-apply in syncds or badass mode. verify that after reload/restart diags logs messages are displayed.
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist