This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix GoDoc comment formatting in t3c-apply source#7038
Merged
zrhoffman merged 1 commit intoapache:masterfrom Aug 26, 2022
Merged
Fix GoDoc comment formatting in t3c-apply source#7038zrhoffman merged 1 commit intoapache:masterfrom
zrhoffman merged 1 commit intoapache:masterfrom
Conversation
ocket8888
added
bug
ericholguin
approved these changes
Aug 26, 2022
Contributor
ericholguin
left a comment
ericholguin
left a comment
There was a problem hiding this comment.
Go fmt errors are fixed. GHA failures not related to this change.
zrhoffman
suggested changes
Aug 26, 2022
Member
zrhoffman
left a comment
zrhoffman
left a comment
There was a problem hiding this comment.
The t3c integration tests keep failing, so I wouldn't feel comfortable merging this PR as-is, since you also include a code change. If you take the code change out/PR it separately, I'd be happy to merge this one, failing tests and all
Contributor
Author
|
The tests are reportedly failing on master. Since I think my code changes fixed a bug, I'm happy to give it a day or two while someone looks into the failures on master and then rebase. If they continue to fail by, say, the end of Monday, I'll just file an issue and take the changes out. |
zrhoffman
approved these changes
Aug 26, 2022
Member
zrhoffman
left a comment
zrhoffman
left a comment
There was a problem hiding this comment.
ehh it has the same failure on master so
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #6960 was erroneously merged with go fmt test failures, resulting in our GHAs failing on master and PR branches thereon based.
This fixes the issue, and also fixes a bug where t3-apply would consider attempting to tail a non-existent file to be a success with no output.
Which Traffic Control components are affected by this PR?
t3c, formerly ORT)What is the best way to verify this PR?
Make sure existing tests pass, ensure the
go fmtGHA now passesIf this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist