This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Use SOH timestamp to calculate bandwidth in TM#7539
Merged
srijeet0406 merged 8 commits intoapache:masterfrom May 31, 2023
Merged
Use SOH timestamp to calculate bandwidth in TM#7539srijeet0406 merged 8 commits intoapache:masterfrom
srijeet0406 merged 8 commits intoapache:masterfrom
Conversation
rimashah25
added
Traffic Monitor
rimashah25
force-pushed
the
bugfix/soh-timestamp
branch
from
9e48e38 to
3420f40
Compare
Codecov Report
@@ Coverage Diff @@
## master #7539 +/- ##
============================================
- Coverage 30.34% 27.74% -2.61%
Complexity 98 98
============================================
Files 790 686 -104
Lines 82622 78116 -4506
Branches 851 90 -761
============================================
- Hits 25075 21675 -3400
+ Misses 55435 54384 -1051
+ Partials 2112 2057 -55
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 108 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rimashah25
force-pushed
the
bugfix/soh-timestamp
branch
from
3420f40 to
112718b
Compare
srijeet0406
suggested changes
May 31, 2023
srijeet0406
suggested changes
May 31, 2023
rimashah25
force-pushed
the
bugfix/soh-timestamp
branch
from
6893c13 to
c0f91d5
Compare
rimashah25
force-pushed
the
bugfix/soh-timestamp
branch
from
c0f91d5 to
c97325b
Compare
srijeet0406
approved these changes
May 31, 2023
jagan-parthiban
pushed a commit
to jagan-parthiban/trafficcontrol
that referenced
this pull request
Jun 2, 2023
* Added current_time_epoch_ms and changes calculation for timestamp for ms * assigning current_time_epoch_ms to result.Time in Handler * updated CHANGELOG.md * Added check for elapsedTime. * Addressed review comments. * Added prevResult check back * pointer assignment for structure. * updated cache unite test with another check.
4 tasks
jagan-parthiban
pushed a commit
to jagan-parthiban/trafficcontrol
that referenced
this pull request
Jun 5, 2023
* Added current_time_epoch_ms and changes calculation for timestamp for ms * assigning current_time_epoch_ms to result.Time in Handler * updated CHANGELOG.md * Added check for elapsedTime. * Addressed review comments. * Added prevResult check back * pointer assignment for structure. * updated cache unite test with another check.
jagan-parthiban
pushed a commit
to jagan-parthiban/trafficcontrol
that referenced
this pull request
Jun 14, 2023
* Added current_time_epoch_ms and changes calculation for timestamp for ms * assigning current_time_epoch_ms to result.Time in Handler * updated CHANGELOG.md * Added check for elapsedTime. * Addressed review comments. * Added prevResult check back * pointer assignment for structure. * updated cache unite test with another check.
jagan-parthiban
pushed a commit
to jagan-parthiban/trafficcontrol
that referenced
this pull request
Jun 14, 2023
* Added current_time_epoch_ms and changes calculation for timestamp for ms * assigning current_time_epoch_ms to result.Time in Handler * updated CHANGELOG.md * Added check for elapsedTime. * Addressed review comments. * Added prevResult check back * pointer assignment for structure. * updated cache unite test with another check.
jagan-parthiban
pushed a commit
to jagan-parthiban/trafficcontrol
that referenced
this pull request
Jun 18, 2023
* Added current_time_epoch_ms and changes calculation for timestamp for ms * assigning current_time_epoch_ms to result.Time in Handler * updated CHANGELOG.md * Added check for elapsedTime. * Addressed review comments. * Added prevResult check back * pointer assignment for structure. * updated cache unite test with another check.
rimashah25
added a commit
that referenced
this pull request
Jun 29, 2023
This reverts commit f3c124f
zrhoffman
pushed a commit
that referenced
this pull request
Jun 29, 2023
rimashah25
added a commit
to rimashah25/trafficcontrol
that referenced
this pull request
Jun 29, 2023
This reverts commit f3c124f
jagan-parthiban
pushed a commit
to jagan-parthiban/trafficcontrol
that referenced
this pull request
Jul 3, 2023
* Added current_time_epoch_ms and changes calculation for timestamp for ms * assigning current_time_epoch_ms to result.Time in Handler * updated CHANGELOG.md * Added check for elapsedTime. * Addressed review comments. * Added prevResult check back * pointer assignment for structure. * updated cache unite test with another check.
srijeet0406
pushed a commit
that referenced
this pull request
Jul 5, 2023
…7545) * Fixes #7544 Updated V5 APIs * Fixes #7544 Updated Integration testing based on RFC3339 Format * Fixes #7544 Added Unit test Cases wherever possible. * CHANGELOG.md Update * Documentation Update * Fixed PR review comments * Use SOH timestamp to calculate bandwidth in TM (#7539) * Added current_time_epoch_ms and changes calculation for timestamp for ms * assigning current_time_epoch_ms to result.Time in Handler * updated CHANGELOG.md * Added check for elapsedTime. * Addressed review comments. * Added prevResult check back * pointer assignment for structure. * updated cache unite test with another check. * Fixed PR review comments for #7544 * Fixed CHANGELOG.md for #7544 * Fixed CHANGELOG.md for #7544 * Fixed CHANGELOG.md for #7544 * Fixed PR review comments for #7544 * Fixed PR Review comments * Fixed CHANGELOG.md * Update stats_summary lib * Updated statessummary file * Updated unit test cases * Temp changes to check GHA * Temp changes to check GHA * revert Temp changes to check GHA * Updated CHANGELOG.md * Updated GHA failing test case for testing. * Updated GHA failing test case. --------- Co-authored-by: Rima Shah <22248619+rimashah25@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is not related to any issue.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
No easy way to test from local but you can test it from staging to see whether TM (calls /_stats endpoint from traffic server for given caches
e.g: curl -Lv http:/<cache_end_point>/_statsand uses and stats _over_http to calculate bandwidth) generates the right amount (doesn't double the value) of bandwidth for bond0 and bond1If this is a bugfix, which Traffic Control versions contained the bug?
7.0.1
PR submission checklist