This repository was archived by the owner on Nov 24, 2025. It is now read-only.
TM - Plugin Systems Stats Timestamp for SOH#7551
Merged
srijeet0406 merged 2 commits intoapache:masterfrom Jun 2, 2023
Merged
Conversation
tcfdev
approved these changes
Jun 2, 2023
Collaborator
tcfdev
left a comment
There was a problem hiding this comment.
LGTM. Thank you for the quick fix!
Codecov Report
@@ Coverage Diff @@
## master #7551 +/- ##
=============================================
- Coverage 65.39% 27.74% -37.65%
Complexity 98 98
=============================================
Files 312 686 +374
Lines 12200 78128 +65928
Branches 885 90 -795
=============================================
+ Hits 7978 21676 +13698
- Misses 3874 54395 +50521
- Partials 348 2057 +1709
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 586 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
srijeet0406
reviewed
Jun 2, 2023
srijeet0406
approved these changes
Jun 2, 2023
rimashah25
added a commit
that referenced
this pull request
Jun 29, 2023
This reverts commit a1bd413.
zrhoffman
pushed a commit
that referenced
this pull request
Jun 29, 2023
rimashah25
added a commit
to rimashah25/trafficcontrol
that referenced
this pull request
Jun 29, 2023
This reverts commit a1bd413.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SOH data will need to include a timestamp when the system stats were queried. This timestamp will be used for being able to calculate bandwidth.
Related: #7539
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
To be tested in staging
If this is a bugfix, which Traffic Control versions contained the bug?
7.0.1
PR submission checklist