Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

TM - Plugin Systems Stats Timestamp for SOH#7551

Merged
srijeet0406 merged 2 commits intoapache:masterfrom
rimashah25:bugfix/tm-timestamp
Jun 2, 2023
Merged

TM - Plugin Systems Stats Timestamp for SOH#7551
srijeet0406 merged 2 commits intoapache:masterfrom
rimashah25:bugfix/tm-timestamp

Conversation

@rimashah25
Copy link
Copy Markdown
Contributor

@rimashah25 rimashah25 commented Jun 2, 2023

The SOH data will need to include a timestamp when the system stats were queried. This timestamp will be used for being able to calculate bandwidth.
Related: #7539


Which Traffic Control components are affected by this PR?

  • Traffic Monitor

What is the best way to verify this PR?

To be tested in staging

If this is a bugfix, which Traffic Control versions contained the bug?

7.0.1

PR submission checklist

Copy link
Copy Markdown
Collaborator

@tcfdev tcfdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the quick fix!

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 2, 2023

Codecov Report

Merging #7551 (cbdb138) into master (ff5a606) will decrease coverage by 37.65%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master    #7551       +/-   ##
=============================================
- Coverage     65.39%   27.74%   -37.65%     
  Complexity       98       98               
=============================================
  Files           312      686      +374     
  Lines         12200    78128    +65928     
  Branches        885       90      -795     
=============================================
+ Hits           7978    21676    +13698     
- Misses         3874    54395    +50521     
- Partials        348     2057     +1709     
Flag Coverage Δ
golib_unit 48.56% <ø> (?)
grove_unit 4.60% <ø> (?)
t3c_unit 5.32% <ø> (?)
traffic_monitor_unit 21.35% <0.00%> (?)
traffic_ops_unit 23.42% <ø> (?)
traffic_portal_v2 ?
traffic_stats_unit 10.14% <ø> (?)
unit_tests 24.40% <0.00%> (-50.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
traffic_monitor/cache/cache.go 42.77% <0.00%> (ø)

... and 586 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Comment thread traffic_monitor/cache/stats_over_http.json
@rimashah25 rimashah25 changed the title TM - Plugin Systems Stats Timestamp to SOH TM - Plugin Systems Stats Timestamp for SOH Jun 2, 2023
@rimashah25 rimashah25 requested a review from srijeet0406 June 2, 2023 21:17
@srijeet0406 srijeet0406 merged commit a1bd413 into apache:master Jun 2, 2023
@rimashah25 rimashah25 deleted the bugfix/tm-timestamp branch June 4, 2023 17:01
@ocket8888 ocket8888 added Traffic Monitor related to Traffic Monitor regression bug a bug in existing functionality introduced by a new version labels Jun 5, 2023
rimashah25 added a commit that referenced this pull request Jun 29, 2023
zrhoffman pushed a commit that referenced this pull request Jun 29, 2023
* Revert "TM - Plugin Systems Stats Timestamp for SOH (#7551)"

This reverts commit a1bd413.

* Revert "Use SOH timestamp to calculate bandwidth in TM (#7539)"

This reverts commit f3c124f
rimashah25 added a commit to rimashah25/trafficcontrol that referenced this pull request Jun 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

regression bug a bug in existing functionality introduced by a new version Traffic Monitor related to Traffic Monitor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants