Changes for ATC 8.0.1 release#7968
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 8.0.1 #7968 +/- ##
=============================================
- Coverage 42.80% 28.76% -14.05%
Complexity 98 98
=============================================
Files 543 600 +57
Lines 39569 77421 +37852
Branches 970 90 -880
=============================================
+ Hits 16938 22269 +5331
- Misses 21385 53056 +31671
- Partials 1246 2096 +850
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
716557b to
7b26c7e
Compare
zrhoffman
left a comment
There was a problem hiding this comment.
Okay, some changes are needed.
-
All of the JS components fail with a message like
`npm ci` can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing.So that needs to be done instead of editing the lockfiles manually.
-
The API contract tests fail on the
8.0.1branch but pass on the master branch. It looks like it has been failing on the8.0.1branch for weeks, so this PR probably does not affect that. The API contract tests must pass. -
There should not be a branch called
8.0.1. The changes should go in the8.0.xbranch, and we should probably never have a branch or tag called8.0.1.
|
I had to close this PR to cherry pick the commits to update go version and node modules from master branch. Refer to this PR to see the updates. |
This PR is not related to any issues. It includes all the changes required for a release
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
N/A
If this is a bugfix, which Traffic Control versions contained the bug?
N/A
PR submission checklist