Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Changes for ATC 8.0.1 release#7968

Closed
rimashah25 wants to merge 3 commits intoapache:8.0.1from
rimashah25:atc-8.0.1-changes
Closed

Changes for ATC 8.0.1 release#7968
rimashah25 wants to merge 3 commits intoapache:8.0.1from
rimashah25:atc-8.0.1-changes

Conversation

@rimashah25
Copy link
Copy Markdown
Contributor

@rimashah25 rimashah25 commented Mar 19, 2024

This PR is not related to any issues. It includes all the changes required for a release


Which Traffic Control components are affected by this PR?

  • Traffic Ops
  • Traffic Router
  • Traffic Portal
  • Version

What is the best way to verify this PR?

N/A

If this is a bugfix, which Traffic Control versions contained the bug?

N/A

PR submission checklist

@rimashah25 rimashah25 requested a review from zrhoffman March 19, 2024 20:30
@rimashah25 rimashah25 added Traffic Router related to Traffic Router Traffic Portal v1 related to Traffic Portal version 1 labels Mar 19, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.76%. Comparing base (89450b3) to head (ff8d368).

Additional details and impacted files
@@              Coverage Diff              @@
##              8.0.1    #7968       +/-   ##
=============================================
- Coverage     42.80%   28.76%   -14.05%     
  Complexity       98       98               
=============================================
  Files           543      600       +57     
  Lines         39569    77421    +37852     
  Branches        970       90      -880     
=============================================
+ Hits          16938    22269     +5331     
- Misses        21385    53056    +31671     
- Partials       1246     2096      +850     
Flag Coverage Δ
golib_unit 53.57% <ø> (ø)
grove_unit 12.02% <ø> (ø)
t3c_unit 5.77% <ø> (-0.12%) ⬇️
traffic_monitor_unit 25.47% <ø> (ø)
traffic_ops_integration 69.42% <ø> (ø)
traffic_ops_unit 21.58% <100.00%> (?)
traffic_portal_v2 ?
traffic_router_unit 29.03% <ø> (ø)
traffic_stats_unit 10.78% <ø> (ø)
unit_tests 25.57% <100.00%> (-13.35%) ⬇️
v3 57.79% <ø> (ø)
v4 79.18% <ø> (ø)
v5 78.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Copy link
Copy Markdown
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, some changes are needed.

  • All of the JS components fail with a message like

    `npm ci` can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing.
    

    So that needs to be done instead of editing the lockfiles manually.

  • The API contract tests fail on the 8.0.1 branch but pass on the master branch. It looks like it has been failing on the 8.0.1 branch for weeks, so this PR probably does not affect that. The API contract tests must pass.

  • There should not be a branch called 8.0.1. The changes should go in the 8.0.x branch, and we should probably never have a branch or tag called 8.0.1.

@zrhoffman zrhoffman added Traffic Ops related to Traffic Ops tests related to tests and/or testing infrastructure process Traffic Portal v2 Related to the experimental Traffic Portal version 2 labels Mar 19, 2024
@rimashah25
Copy link
Copy Markdown
Contributor Author

I had to close this PR to cherry pick the commits to update go version and node modules from master branch. Refer to this PR to see the updates.

@rimashah25 rimashah25 closed this Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

process tests related to tests and/or testing infrastructure Traffic Ops related to Traffic Ops Traffic Portal v1 related to Traffic Portal version 1 Traffic Portal v2 Related to the experimental Traffic Portal version 2 Traffic Router related to Traffic Router

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants