This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Changes for ATC 8.0.1 release#7969
Merged
zrhoffman merged 19 commits intoapache:8.0.xfrom Mar 20, 2024
Merged
Conversation
Update chromedriver (cherry picked from commit 8d1b4e3)
Update chromedriver (cherry picked from commit 578f04e)
Update chromedriver (cherry picked from commit f91c341)
Update chromedriver (cherry picked from commit a423170)
…ache#7945) Bumps [ip](https://github.com/indutny/node-ip) from 1.1.8 to 1.1.9. - [Commits](indutny/node-ip@v1.1.8...v1.1.9) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 6c6eebc)
…pache#7951) Bumps [es5-ext](https://github.com/medikoo/es5-ext) from 0.10.62 to 0.10.64. - [Release notes](https://github.com/medikoo/es5-ext/releases) - [Changelog](https://github.com/medikoo/es5-ext/blob/main/CHANGELOG.md) - [Commits](medikoo/es5-ext@v0.10.62...v0.10.64) --- updated-dependencies: - dependency-name: es5-ext dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit e05e709)
Update chromedriver (cherry picked from commit 1464dc2)
Co-authored-by: asf-ci-trafficcontrol <asf-ci-trafficcontrol@users.noreply.github.com> (cherry picked from commit dc995a9)
Update chromedriver (cherry picked from commit 26a2f6a)
11871a6 to
74e6dea
Compare
4 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 8.0.x #7969 +/- ##
============================================
- Coverage 31.75% 28.87% -2.89%
Complexity 98 98
============================================
Files 717 850 +133
Lines 82786 90980 +8194
Branches 970 970
============================================
- Hits 26289 26268 -21
- Misses 54339 62548 +8209
- Partials 2158 2164 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
|
Everything that depends on TO seems to be failing, probably from this (from the Go Vet run: # github.com/apache/trafficcontrol/v8/traffic_ops/traffic_ops_golang/deliveryservice/servers
Error: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go:770:20: undefined: api.Info
# github.com/apache/trafficcontrol/v8/traffic_ops/traffic_ops_golang/deliveryservice/servers
# [github.com/apache/trafficcontrol/v8/traffic_ops/traffic_ops_golang/deliveryservice/servers]
Error: vet: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go:770:20: undefined: api.Info |
zrhoffman
suggested changes
Mar 20, 2024
Member
zrhoffman
left a comment
There was a problem hiding this comment.
Everything looks good except the contract tests. Happy to approve once those pass too
a9ff41b to
cc4e70d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is not related to any issues. It includes all the changes required for a release
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
N/A
If this is a bugfix, which Traffic Control versions contained the bug?
N/A
PR submission checklist