Skip to content

Reduce the default size of max header sizes#11344

Merged
maskit merged 1 commit intoapache:masterfrom
maskit:max_header_size
Jun 7, 2024
Merged

Reduce the default size of max header sizes#11344
maskit merged 1 commit intoapache:masterfrom
maskit:max_header_size

Conversation

@maskit
Copy link
Copy Markdown
Member

@maskit maskit commented May 13, 2024

No description provided.

@maskit maskit added this to the 10.0.0 milestone May 13, 2024
@maskit maskit self-assigned this May 13, 2024
@maskit
Copy link
Copy Markdown
Member Author

maskit commented May 13, 2024

[approve ci autest]

@JosiahWI
Copy link
Copy Markdown
Contributor

AuTest proxy_serve_stale_dns_fail failed.

@bryancall bryancall self-requested a review May 13, 2024 22:14
Comment on lines -4461 to -4462
that the sender is prepared to accept blocks. The default value, which is
the unsigned int maximum value in |TS|, implies unlimited size.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this default statement simply incorrect?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the sentence was not updated on #5319.

@maskit maskit requested a review from bneradt June 4, 2024 20:27
@maskit
Copy link
Copy Markdown
Member Author

maskit commented Jun 4, 2024

There's no blockers, right?

@maskit maskit merged commit 6a0bce6 into apache:master Jun 7, 2024
@cmcfarlen
Copy link
Copy Markdown
Contributor

Cherry-picked to v10.0.x

cmcfarlen pushed a commit that referenced this pull request Jun 10, 2024
@bryancall bryancall mentioned this pull request Aug 15, 2024
91 tasks
@maskit maskit deleted the max_header_size branch September 18, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: picked-10.0.0

Development

Successfully merging this pull request may close these issues.

5 participants