Doc: fix some default parameter on records.config#5319
Merged
randall merged 2 commits intoapache:masterfrom Apr 24, 2019
nozomi1773:master
Merged
Doc: fix some default parameter on records.config#5319randall merged 2 commits intoapache:masterfrom nozomi1773:master
randall merged 2 commits intoapache:masterfrom
nozomi1773:master
Conversation
Contributor
|
[approve ci] |
SolidWallOfCode
approved these changes
Apr 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that some default parameter on the document is incorrect.
I corrected it to the correct value referring to the following source code.
proxy.config.ssl.server.ticket_key.filename
trafficserver/mgmt/RecordsConfig.cc
Line 1131 in 1e9e4ed
proxy.config.http2.max_header_list_size
trafficserver/mgmt/RecordsConfig.cc
Line 1322 in 1e9e4ed