TS-4143 Validate host in GET URL#430
Closed
danobi wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
Member
There was a problem hiding this comment.
I think here the condition should be to check host._size first and then for validate_host_hdr either set the host (if success) or generate an error (if false). It is acceptable to not have a host at all in the URL, but it is unacceptable (an error) if there is a host and it's malformed.
Also moved all the host validation logic to URL.cc since HTTP.cc inherits from URL.cc.
SolidWallOfCode
pushed a commit
to SolidWallOfCode/trafficserver
that referenced
this pull request
Apr 13, 2017
Ftywan
pushed a commit
to Ftywan/trafficserver
that referenced
this pull request
Dec 21, 2022
* s3_auth: accept longer config lines * Tell CI to ignore intentional trailing spaces Rename v4-parse-test.conf to .test_input * Address PR review comments * Remove spurious os import Co-authored-by: Mo Chen <uncorrupt@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also moved all the host validation logic to URL.cc since HTTP.cc
inherits from URL.cc.