s3_auth: accept longer config lines#9090
Merged
vmamidi merged 4 commits intoapache:masterfrom Sep 21, 2022
Merged
Conversation
moonchen
force-pushed
the
s3-auth-long-config
branch
from
1fa4548 to
a8455a4
Compare
Rename v4-parse-test.conf to .test_input
bneradt
requested changes
Sep 20, 2022
moonchen
force-pushed
the
s3-auth-long-config
branch
from
25206ca to
062e937
Compare
bneradt
requested changes
Sep 20, 2022
bneradt
approved these changes
Sep 20, 2022
Contributor
|
Setting for 9.2.x per @moonchen 's request. The change should be pretty safe and he added quite a bit of testing for the parts he changed. And it sounds like Apple will be running with this internally as well so if there are issues they'll most likely find it there. |
zwoop
pushed a commit
that referenced
this pull request
Oct 4, 2022
* s3_auth: accept longer config lines * Tell CI to ignore intentional trailing spaces Rename v4-parse-test.conf to .test_input * Address PR review comments * Remove spurious os import (cherry picked from commit cd712e0)
Contributor
|
Cherry-picked to v9.2.x |
Ftywan
pushed a commit
to Ftywan/trafficserver
that referenced
this pull request
Dec 21, 2022
* s3_auth: accept longer config lines * Tell CI to ignore intentional trailing spaces Rename v4-parse-test.conf to .test_input * Address PR review comments * Remove spurious os import Co-authored-by: Mo Chen <uncorrupt@gmail.com>
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Feb 21, 2023
* asf/9.2.x: Updated ChangeLog s3_auth: Fix parsing of virtual_host (apache#9103) s3_auth: accept longer config lines (apache#9090) Add a proxy.config.http.per_server.connection.max test (apache#9097) Move plugin_init for verify cmd (apache#9102) Fix unused-but-set-variable warnings by llvm-15 (apache#9106) Fix compile error with llvm-15 (apache#9105) Fix expected sha1sum for the Proxy Verifier binary (apache#9112) Updating AuTest to use Proxy Verifier v2.4.2 (apache#9110)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow arbitrarily long config lines in s3_auth config files. Previously the limit was 511 characters.
Add autest for config parsing.